cinder.go does not respect the TLS config settings about openstack-exporter HOT 10 CLOSED

We were able to validate that the latest master does work.

from openstack-exporter.

@marklcg

Hello mark,

Thanks for your report. What's the problem/bug/error you are seeing due to this?

from openstack-exporter.

Certificate trust issues in our case. We can work around it by adding the certs to /etc/ssl in our container. So we do have a work around.

EDIT: I should add that I understand that disabling verification is really the work around and adding the cert is the correct thing to do. That said, it is nice to have the configuration option and probably should be consistent with the other exporter code.

from openstack-exporter.

@marklcg
The TLSConfig is defined before the cinder exporter gets instantiated, Do you have any traceback/debug logs to see the specific error you are seeing?

from openstack-exporter.

Sure, we were seeing this error even with our cloud auth.verify set to false. It ignores the cert for all the other metrics, just not cinder:

time="2019-07-19T17:09:07Z" level=error msg="Get https://xx.xx.xx.xx:13776/v3/51285243fc0241e9ab74efb20a0736b2/volumes?all_tenants=1: Get https://xx.xx.xx.xx:13776/v3/51285243fc0241e9ab74efb20a0736b2/volumes?all_tenants=1: x509: certificate signed by unknown authority" source="cinder.go:92"

from openstack-exporter.

@marklcg

Thank you for the detailed report. Could you please test the latest image from [0] master and report on this bug?, this commit [1] should pass the tls configuration to the cinder client as it's done with the other service exporters.

[0] quay.io/niedbalski/openstack-exporter-linux-amd64:master
[1] 6c96a2f

from openstack-exporter.

@marklcg

I've tested it with verify false and a set of self-signed certificates, all seems to work. I am waiting on your confirmation to release 0.2.0

Thank you

from openstack-exporter.

Sorry for slow response, I'll see if we can grab the latest to confirm, but I suspect you are correct--we were using an old version. I'm OK with closing this for now and if we see it with the latest when we get to it, re-opening. Sound OK?

from openstack-exporter.

@marklcg

I think is a valid bug, can you check the latest master image to see if the problem is still reproducible?

Thanks

from openstack-exporter.

Thanks, marking this as fixed.

from openstack-exporter.