Comments (7)
Good point!
So embarrassed I missed the empty alt tags for decorative images that I fixed it right away :O 8bf9fef
Also did a first compression of the project images.
WAVE has no other complaints for now, will go through it with Lighthouse tomorrow.
from opensourcediversity.org.
Dont panic, It will be something that needs checking at regular intervals. Colours can also be an issue it will probably not like the menu buttons contrast in the top nav.
from opensourcediversity.org.
@sleepypioneer Checked the color contrast of background color #45B086 and white and the contrast ratio is only 2.69:1 - which fails WCAG.
Solution would be to make green darker (eg. #28624E) or color of the text black (which also means black background). I am in favour of darkening the green - but ultimately this is a design decision.
The site itself could also benefit from greater line height and spacing between rows of elements.
from opensourcediversity.org.
Hi @22nds great to see you here! @jancborchardt is our design Guru so I will leave this to him, thanks for checking :)
from opensourcediversity.org.
I enhanced the readability a bit:
- Added a slight text-shadow to the white text which on green
- Made the navigation text fully opaque white by default
- Added the hover/focus effect for the navigation links too
Changing the text/foreground color from white to dark definitely looks a bit negative (or what do you think?):
Darkening the background color also makes it a bit gloomy, but maybe we need to find the correct balance there?
The site itself could also benefit from greater line height and spacing between rows of elements.
@22nds great point! Fixed it with e74222e
I’ll look into changing the Light & Semibold font combination to Regular & Bold for better readability.
from opensourcediversity.org.
Fonts are now changed to Regular & Bold, much better! :)
And a pull request with compressed images is at #16
from opensourcediversity.org.
Closing as we fixed the basic issues. If there’s stuff left or new things coming up, please open new issues! :)
from opensourcediversity.org.
Related Issues (20)
- Please invite me to the GitHub Community Organisation #401
- Yourfirstpr repository has been archived, removal from basics section HOT 4
- Modernize Continuous Integration pipeline
- Fix failing HTML checks HOT 12
- No scroll when items are clicked on navigation bar (CROSS BROWSER ISSUE) HOT 2
- Join this organization HOT 1
- Migrate site to React-based framework, like Docusaurus HOT 18
- Please invite me to the GitHub Organization HOT 1
- Transparency issue: who pays the bills? HOT 4
- Outdated links for Open Source Diversity Berlin and Diversify Open Source Bangalore in spaces section. HOT 6
- Circle CI Lint Broken HOT 2
- Link to "Women Hack for Non Profits" gives 404 HOT 1
- Remove links to open collective HOT 1
- Contributor Code of Conduct - Link - Error HOT 2
- Hamburger menu is broken in mobile HOT 10
- Hamburger menu is broken in mobile HOT 1
- Heb
- Contributer LInks are not working in readme.md file HOT 1
- Broken link on the web site HOT 4
- Update ui/ux design .... HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opensourcediversity.org.