Comments (4)
Hmm, with a non-OK content it should probably fail. What does @siamaksade @thoraxe think?
I am not against having health endpoints, but how should they behave? The integral part of the deployment is the content, if the content is not OK, why would health endpoint report healthy state?
from workshopper.
I don't think it's needed. Each deployment need to define probes that are specific to its content to be able to detect issues like that for example to /workshop/cloudnative/lab/getting-started
from workshopper.
Jorge's content wasn't rendering and therefore the liveness/readiness probes got 500s which count as failures. The container would've been restarted (failed liveness) and eventually the deployment would be considered failed.
It sounds like the behavior was correct and is exactly what we want and what's expected. If we had a /healthz
endpoint, you wouldn't have known you had a problem unless you visited the app. The app would've been "broken" but happily passed liveness/readiness, which doesn't sound right.
This doesn't sound like a bug or a reason to implement /healthz
.
Am I misinterpreting?
from workshopper.
OK, the agreement seems to be that it should not be there.
Let's reopen in case we find a use-case for such endpoints.
from workshopper.
Related Issues (20)
- Documentation HOT 3
- Add scroll to "table of contents" HOT 5
- Clipboard vs. navigation HOT 1
- Add different indicator of copy and paste HOT 1
- Make issues configurable per workshop HOT 1
- Ctrl-C does not stop the process HOT 2
- Add a flag to log output to stdout for debugging HOT 1
- Support workshops with alternate labs
- Ability to supply custom CSS or JS HOT 6
- (Markdown) Allow setting image size
- Variables are not replaced HOT 1
- copypaste css no longer works in latest builds HOT 1
- workshopper not rendering certain variables HOT 1
- Create workshopper image in OpenShift
- support reload with docker image
- Calculate CONTENT_URL_PREFIX if not specified and 'content.url' not set in workshops file. HOT 1
- asciidoctor-reveal.js
- Install issue in openshift
- [RFE] Don't parse variables escaped with pass macro HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from workshopper.