Git Product home page Git Product logo

Comments (4)

dsmiley avatar dsmiley commented on June 5, 2024

Very cool! After we switch to Java 8 (which I see this code requires as it uses .stream()), what do you think of providing this code with the text tagger? It would probably result in another module but I think that's better than separate projects altogether.

from solrtexttagger.

westei avatar westei commented on June 5, 2024

I should definitely be an own module (as it only depends on SolrJ and does not have a direct dependency to the SolrTextTagger module. I have no problem of managing it at the above location, but maybe SolrTextTagger user will more likely find it when it is made available under the same groupId as the solr-text-tagger.

Regarding Java 8: I was in the impression that Solr 6 requires Java 8. In SolrJ they renamed some of the main classes with Solr 6. So to support older Java versions one would need to provide two separate releases (one for SolrJ 6 and SolrJ 5)

from solrtexttagger.

dsmiley avatar dsmiley commented on June 5, 2024

I just released 2.3 and bumped the tagger to Solr 6 and Java 8.

Yes, Solr 6 requires Java 8.
Feel free to send a pull request for this contribution. Perhaps the SolrJ module can be a child of the existing one, without having to move the current code to a new subdirectory -- that'd be nice.

from solrtexttagger.

dsmiley avatar dsmiley commented on June 5, 2024

Now that Solr 7.4.0 includes the tagger, perhaps you might want to propose your addition directly to Apache Solr / SolrJ.

from solrtexttagger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.