Git Product home page Git Product logo

Comments (3)

peterzhuamazon avatar peterzhuamazon commented on July 17, 2024 1

Hi Sushma,

Based on the original code of branch cut.
It does not use any jenkins lib nor does it engage build python code.
It is simply a couple of git commands doing the checkout and push again with new branch name:
https://github.com/opensearch-project/opensearch-build/blob/opensearch-2.14.0/jenkins/release-branch/release-branch.jenkinsfile

Probably a few tweaks to branch cut workflow to help improve the version enforcing:

  1. Add a param / option to enforce the version check: VERSION_CHECK: <VERSION>.
  2. Use either gradle or yarn based on the input manifest provided to do a simple version check.
  3. If version mismatch, do not fail the entire run but rather save the component in a list and report later without cutting that specific branch.

We can also add a version check standalone workflow if needed and use it as a pre-requisite of branch cut, tho that might be an overkill at the moment.

Thanks.

from opensearch-build.

peterzhuamazon avatar peterzhuamazon commented on July 17, 2024

Trying to monitor the version bump in potential central release dashboards improvements:

from opensearch-build.

gaiksaya avatar gaiksaya commented on July 17, 2024

Hi @5u5hma,

Creating a release branch via automation is something that we added recently. Please note that we take this action only on the day of first release candidate creation. This is more of a proactive measure instead to avoid build failures. As @peterzhuamazon mentioned, we can add a check to make sure versions are bumped before a branch is cut via automation workflow. However, each repo has its own maintainers and codeowners that might decide to cut branch when they want which includes before the version bump, etc which we or the automation workflow has no control over whatsoever. I believe this will be still be an edge case for automation mentioned in issue description.

@dblock @prudhvigodithi Please add your thoughts if any.

from opensearch-build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.