Dark mode about interactivehtmlbom HOT 7 CLOSED

This have to wait the GUI as you propose. In the GUI a comboBox could allow choose between dark / light theme, collapse references or not.

from interactivehtmlbom.

I like to your way to keep just one file (because this I did #19). So maybe create different CSS styles on the plugin folder and merge it inside the html on the final process.

from interactivehtmlbom.

Even the java script and other could be a external file added by the python code in the final HTML. This will allow some users to easy modify the HTML template adding some personal logo (example).
But most important you could keep the *.js file format indented and remove the '\n' in the moment before add at the html.

from interactivehtmlbom.

I was thinking to have dark/light mode be a toggle in html itself so that you could change it dynamically.

On splitting js and css, that is a good idea, although not because of indentation. Js that is not indented is minified anyway.

from interactivehtmlbom.

Agree with your way, keep light and dark selected by a checkbox on final HTML file will be better.
Split the files is just a try to help you with maintenance, since the PCB data is injected on '///PCB///', the same could be done with the CSSs (the already existent and the dark one), even minified (minimize spaces and '\n"=') through a python replace / regular expression function.
Because of the size of the example project the I sent on other discussion, I am always concern about file size and light interpretation.

from interactivehtmlbom.

Rendering of the canvas is the biggest CPU/GPU consumer, parsing the file is nothing in comparison so I won't spend too much time on it.
Also in the large board you posted in the other issue, 99% of the html file volume is the pcbdata, which is already compact as it is. Some corners can be cut there like using shorter string keys and reducing floating point precision, but ultimately not much, unless I switch to a compact serialization protocol, something like protobuf. But that is a huge dependency to pull in, which I will only do if wins are really justified.
Anyway, we digress :) Lets keep this bug about dark mode.

from interactivehtmlbom.

When in dark mode, the board edge should go white? Just a question about the better contrast to visualize.

from interactivehtmlbom.