Git Product home page Git Product logo

Comments (8)

rgieseke avatar rgieseke commented on June 3, 2024

Good point. These examples assume that you have a run_tests.py script ...

Not sure what the best example is.
We could just use

make test

Would that work?

#!/bin/bash
export MAGICC_EXECUTABLE_7=tmp/magicc/run/magicc.exe
make test

from pymagicc.

matthiasmengel avatar matthiasmengel commented on June 3, 2024

This works. The virtual environment is successfully built. I then arrive at #92.
make test is kind of big and probably intimidating for some. How did the run_tests.py look like?
There are people who know python, but not make.

from pymagicc.

rgieseke avatar rgieseke commented on June 3, 2024

I think these were meant as examples similar to filenames in the main MAGICC dev repo. There is at least a generate_plots.py script there.

We could have simple example scripts for testing in the Pymagicc repo.

from pymagicc.

znicholls avatar znicholls commented on June 3, 2024

I'm against having a Python run_tests.py, unless all it does is call make test. Having the test in multiple places will be a nightmare re maintenance and debugging I fear...

from pymagicc.

rgieseke avatar rgieseke commented on June 3, 2024

Yes, we should find a workable example for the Readme, maybe the generate_plots.py which should run. Just to ensure that it works in principle. Or even better, a simple script which just prints the MAGICC version.

from pymagicc.

znicholls avatar znicholls commented on June 3, 2024

isn't this what the notebooks are for?

from pymagicc.

rgieseke avatar rgieseke commented on June 3, 2024

Could just be a simple script that enables you to check (or debug someone else's setup) whether the environment var works.

from pymagicc.

znicholls avatar znicholls commented on June 3, 2024

Could just be a simple script that enables you to check (or debug someone else's setup) whether the environment var works.

Alright. I don't like the duplication but I can see why it's worth it.

from pymagicc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.