Git Product home page Git Product logo

Comments (2)

mskalski avatar mskalski commented on July 17, 2024

No -error is because from variable (initialized to mfile->pt) is not checked if it is properly \0-terminated.

It should be checked if read does not exceed buffer boundary using maybe memchr() function instead of strchr()?

from pam_pkcs11.

bowb avatar bowb commented on July 17, 2024

I have also found memory leaks and I am working on cleaning them up. There is also an issue with the from++ reading an invalid byte in valgrind. I'm thinking about the following to fix both of these issues:

while(*from && isspace(*from)) {
   if(from - mfile->buffer +1 >= mfile->length) {
      return 0;
   }
   from++;
}

from pam_pkcs11.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.