Git Product home page Git Product logo

Comments (5)

xkopenreview avatar xkopenreview commented on August 14, 2024

this is a tough one
it is executing window.location and window object is null thus the complain.
i've thought it's related to the way next or react handles dom manipulation until i notice this in invitation.js

image

removing the assignment of document and window will make the error go away
but i don't know what these two lines are for.
@zbialecki

from openreview-web.

zbialecki avatar zbialecki commented on August 14, 2024

This code was added as a temporary security measure to prevent webfield code written by third parties from accessing the global objects and doing bad things (like redirecting to a phishing site or something). I think that we can remove these lines however, since 1) we are still writing all the webfields and 2) the real solution for securely running 3rd party code is to run it in an iframe in a sandboxed environment.

from openreview-web.

zbialecki avatar zbialecki commented on August 14, 2024

I'm actually surprised that this webfield works in the live site at all. I would expect any reference to window or document to throw an error. A search of openreview-py shows that this template is the only place that either of those vars are used, so I think the real solution for now would be to change that line of code in the webfield to just use location, not window.location

from openreview-web.

xkopenreview avatar xkopenreview commented on August 14, 2024

as discussed in daily meeting, this issue has been assigned to Mohit to make the changes in webfield code.
@mohituniyal
at the top melisa has the link she used to test

from openreview-web.

zbialecki avatar zbialecki commented on August 14, 2024

Fixed by openreview/openreview-py#706

from openreview-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.