Comments (5)
this is a tough one
it is executing window.location and window object is null thus the complain.
i've thought it's related to the way next or react handles dom manipulation until i notice this in invitation.js
removing the assignment of document and window will make the error go away
but i don't know what these two lines are for.
@zbialecki
from openreview-web.
This code was added as a temporary security measure to prevent webfield code written by third parties from accessing the global objects and doing bad things (like redirecting to a phishing site or something). I think that we can remove these lines however, since 1) we are still writing all the webfields and 2) the real solution for securely running 3rd party code is to run it in an iframe in a sandboxed environment.
from openreview-web.
I'm actually surprised that this webfield works in the live site at all. I would expect any reference to window or document to throw an error. A search of openreview-py shows that this template is the only place that either of those vars are used, so I think the real solution for now would be to change that line of code in the webfield to just use location
, not window.location
from openreview-web.
as discussed in daily meeting, this issue has been assigned to Mohit to make the changes in webfield code.
@mohituniyal
at the top melisa has the link she used to test
from openreview-web.
Fixed by openreview/openreview-py#706
from openreview-web.
Related Issues (20)
- Profile Editor - Don't show imported publications section when there's no imported publication
- Pronouns text showing up when pronouns not selected
- Group homepage - MathJax is not being executed
- Display odate in submission forum UI HOT 1
- Home page - all venues highlight is wrong HOT 1
- Edge browser - score and count may overlap when score is long
- Profile improvements HOT 2
- PC Console: When a PC has a conflict with a paper, show conflict instead of displaying no info
- Add an evaluation stage for actors (reviewers, ACs, SACs) in conference HOT 2
- Remove hardcoded roles in hashes of URLs
- DBLP link warning HOT 1
- PC-AC Status: Use completedRecs instead of completedBids when displaying reviewer recommendations
- Consoles: Extract console tabs into components
- Avoid API is unavailable in the home page HOT 1
- Consoles: limit the number of reminders sent
- DatePicker widget - support maximum and minimum HOT 1
- Reviewer Console: Add tests for tabs
- SAC console: show withdrawn papers
- PC/SAC console: Don't show AC name if there are no assigned ACs HOT 1
- PC Console: Enable PCs to email submission Authors from Submission Status HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openreview-web.