Change lock/veto to upvote/downvote about openreview-matcher HOT 4 CLOSED

I think we initially considered up and down arrows, but decided against them because they were going to be used for setting hard constraints. If that is no longer the case then I wouldn't mind re-naming them and giving them different icons.

from openreview-matcher.

At one point I thought that up/down arrows might be a better way to move reviewers from the primary list to the alternate list or vice-versa but came to the conclusion that it didn't really matter that much because the representation of a primary list and alternate list made it pretty clear to me what the impact of my actions was. It does not give the impression of "voting". When I see a reviewer move from primary list to the alternates list, this does not feel like a suggestion. It feels more like a command in that I have just edited the model and its reviewers lists now reflects that edit.

So if you are wanting to give an impression that a user is making suggestions through voting, I think more needs to change than the name we give to the buttons.

So I'm making some assumptions about how you might be envisioning this working in a multi-user situation (e.g. multiple PCs manipulating a single paper's reviewer list). Each up-vote would increase a reviewer's vote count and each down-vote would decrease it Would the primary list then contain those reviewers with the most votes and the alternates list shows those with less? Each list could be sorted by number of votes.

Going into the implementation a bit here: I think I'm also hearing you say that up/down votes might still work as a hard-constraint (which we currently achieve by using +inf/-inf as paper-user scores in the constraints list) but in the future it might be more of a vote tally. We'd then be able to make some changes to the algorithm to use these votes in a different way than we use hard constraints.
If I'm on the mark with this, we might then need some UI control other than voting if a PC really wants to veto or lock a reviewer rather than vote!

from openreview-matcher.

We decided to try out using a green plus and a red minus for the buttons.

from openreview-matcher.

Outdated

from openreview-matcher.