Git Product home page Git Product logo

Comments (5)

tfmorris avatar tfmorris commented on June 4, 2024

I'm not sure I understand "limitation automatically confirmed" but if the intent is that the checkbox just track whether or not the field is populated with a number, perhaps the checkbox is not needed at all.

from openrefine.

thadguidry avatar thadguidry commented on June 4, 2024

The checkbox is not needed at all, but there should be a visual highlight somehow that the input box is filled and that this has Enabled the option. Not sure what the best way to present "Enabled" is. A checkbox works, but we don't want the user to have the sense that it's interactive. We need some other visual indicator to show "Enabled" without the feeling of interactivity needed. I've often seen Red color used around border for required input boxes not filled in. But what about the opposite? Wonder what other frameworks do?

A blue border perhaps when it's filled and effectively "Enabled" with a blue checkbox indicator at the left/right end of the input box, might work well?
Example: https://codepen.io/thadguidry/pen/YzgOaZM

image

from openrefine.

wetneb avatar wetneb commented on June 4, 2024

Removing "good first issue" because there is still an ongoing discussion about the design.

from openrefine.

tfmorris avatar tfmorris commented on June 4, 2024

A similar argument could be made for two nearby fields which default to 0:

  Ignore first 0 line(s) at beginning of file
  Discard initial 0 row(s) of data

In my opinion, a better UI would be to:

  1. remove the checkboxes
  2. make the entry fields numeric with a default value of 0

This would enable the up/down errors to increment the field value which would make it easy for the user to select the, typically small, values that they want.

The max lines field probably needs to stay a string with a default value of empty which gets validated and parsed to an integer on user entry (unless there's a way to have a numeric field with an empty, non-zero, default).

What brought this issue to mind though is the radio control in the middle controlling whether the first line(s) contain header(s) or not. Although I intellectually known that round means radio button, I inevitably try to uncheck the radio button, before I remember that I need to click column names button (even though I don't want to provide column names). I don't have a proposed solution for this, but seems like we might as well clean up this whole section of the dialog at once.

from openrefine.

cooperzoe avatar cooperzoe commented on June 4, 2024

I agree, I think we should

  1. Removed the checkboxes
  2. Make the default lines zero - perhaps this would erase the need for marking it enabled?

from openrefine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.