Comments (5)
I'm not sure I understand "limitation automatically confirmed" but if the intent is that the checkbox just track whether or not the field is populated with a number, perhaps the checkbox is not needed at all.
from openrefine.
The checkbox is not needed at all, but there should be a visual highlight somehow that the input box is filled and that this has Enabled the option. Not sure what the best way to present "Enabled" is. A checkbox works, but we don't want the user to have the sense that it's interactive. We need some other visual indicator to show "Enabled" without the feeling of interactivity needed. I've often seen Red color used around border for required input boxes not filled in. But what about the opposite? Wonder what other frameworks do?
A blue border perhaps when it's filled and effectively "Enabled" with a blue checkbox indicator at the left/right end of the input box, might work well?
Example: https://codepen.io/thadguidry/pen/YzgOaZM
from openrefine.
Removing "good first issue" because there is still an ongoing discussion about the design.
from openrefine.
A similar argument could be made for two nearby fields which default to 0:
Ignore first | 0 | line(s) at beginning of file |
---|
Discard initial | 0 | row(s) of data |
---|
In my opinion, a better UI would be to:
- remove the checkboxes
- make the entry fields numeric with a default value of 0
This would enable the up/down errors to increment the field value which would make it easy for the user to select the, typically small, values that they want.
The max lines field probably needs to stay a string with a default value of empty which gets validated and parsed to an integer on user entry (unless there's a way to have a numeric field with an empty, non-zero, default).
What brought this issue to mind though is the radio control in the middle controlling whether the first line(s) contain header(s) or not. Although I intellectually known that round means radio button, I inevitably try to uncheck the radio button, before I remember that I need to click column names button (even though I don't want to provide column names). I don't have a proposed solution for this, but seems like we might as well clean up this whole section of the dialog at once.
from openrefine.
I agree, I think we should
- Removed the checkboxes
- Make the default lines zero - perhaps this would erase the need for marking it enabled?
from openrefine.
Related Issues (20)
- Integer divide by zero returns null instead of error or infinity HOT 2
- Support scientific / exponential notation in GREL HOT 3
- Get rid of most/all uses of java.util.Properties HOT 14
- Get() or array indexing of numbers & dates should be an error
- Add an evaluate() GREL function which interprets a string as GREL
- Add an icon in line with the new visual guidelines of MacOS HOT 2
- Replace use of java.util.Properties in Bindings HOT 2
- Remove use of java.util.Properties for URL query parsing utility HOT 6
- Log Java version during Server startup to help troubleshooting from users
- beta: deleting single cell contents and pressing enter repopulates textbox HOT 14
- Operation logos
- Excel importer doesn't work from URL HOT 6
- Replace Properties with Map<String, String> in Exporters interfaces HOT 1
- Incorrect export of escaped quotation marks HOT 2
- Refresh dependency licenses in the About page HOT 4
- Null pointer exception in Wikibase edits operation
- Require Developer Certificate of Origin (DCO) signoff on all commits? HOT 1
- Sample extension's About page errors HOT 2
- MarcImporterTests inherits from XmlImporterTests
- Inconsistent location of Extract / Apply button HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrefine.