explain how to use RCT2_CALLPROC_X, RCT2_CALLPROC_EBPSAFE, RCT2_CALLFUNC_X about openrct2 HOT 4 CLOSED

use RCT2_CALLPROC_EBPSAFE when there are no register parameters.
use RCT2_CALLPROC_X when registers are only used as input parameters.
use RCT2_CALLFUNC_X when registers are used as input / output parameters.

from openrct2.

When is it appropriate to wrap these? For example, do_game_command is called a lot of times and yet currently is each time called with RCT2_CALLPROC_X. In addition, specific to do_game_command, do we know what any of it's arguments are?

from openrct2.

i have written do_game_command now, but its arguments depend on the command type (esi) - so for now its still registers as input.

You can wrap them so long as you are able to name them.

from openrct2.

Ok I added the following documentation to the wiki. More probably needed but hopefully ok for the moment. https://github.com/IntelOrca/OpenRCT2/wiki/Decompiling-Tips#subroutines

from openrct2.