Git Product home page Git Product logo

Comments (3)

Harry-Hopkinson avatar Harry-Hopkinson commented on May 12, 2024

I would like to work on this issue, what should happen when the object selection window is closed? Should it take the user back to the main menu?

from openrct2.

zzril avatar zzril commented on May 12, 2024

I would like to work on this issue, what should happen when the object selection window is closed? Should it take the user back to the main menu?

I think proceeding to the actual track design step is fine.
It should just do it in the same way as when clickling the "next" button in the bottom toolbar. I. e. run CheckObjectSelection() first and FinishObjectSelection() only if that succeeded. And also open the ride construction window then.


I have noticed the same in the scenario editor btw. Closing the object selection window allows you to proceed to the landscape editor in an "invalid state", e. g. with no entrance selected.
(The landscape editor then gives you an option to place an invisible park entrance that guests will not be able to walk through.)

Again, proceeding to the next editor step is fine here, but it should happen in the same way as when doing it via the "next" button.


Ideally, closing the object selection window (and thereby proceeding to the next scenario editor / track designer step) should also be possible by pressing backspace.
Currently, pressing backspace closes and immediately re-opens the window in the track designer, while simply nothing happens when doing so in the scenario editor.

from openrct2.

Harry-Hopkinson avatar Harry-Hopkinson commented on May 12, 2024

Does it look good how it is implemented in the PR. If the user tries to close the track designer window without an object selected they get the same error message that they would if they attempted to close using the next button on the toolbar. The same functionality also works in the Track Designer manager where it will not allow the user to close without selecting an object.

from openrct2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.