Potentially uninitialized local pointer variable in game.c about openrct2 HOT 5 CLOSED

Seems like you're trying to build the game with the Debug configuratipn. Switch to Release build. The settings for the Debug build are a bit over restrictive.

from openrct2.

Although saying that there is a good point that widget will potentially be not initialized see line 520 (input_mouseover). I think there should probably be an else return but i would have to check the original code. Same for the other function at line 621 (input_leftmousedown). These will need to be fixed at some point so don't close the bug.

from openrct2.

Does this still apply to the current code?

from openrct2.

The code has moved to https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/input.c#L798 and I don't think this warning is valid. I ceratinly haven't seen it with clang/gcc compiles.

in line 798 widget is declared without explicit assignment, in line 800 if (w != NULL) then in line 803 widget has value assigned. In line 808, which was previously 526 mentioned in original report, there is a check if (w != NULL && widgetIndex != -1 && widget->type == WWT_SCROLL) which dereferences widget if and only if w != NULL, which guaranteed value assignment in line 803 above.

An assert could be added just after assignment in line 803 to see if widget is not NULL, but otherwise it looks fine.

from openrct2.

Considering the changes since 2014 and janisozaur's comment I'll assume this no longer applies to the current state of the code.

from openrct2.