Git Product home page Git Product logo

Comments (5)

mhillenbrand avatar mhillenbrand commented on May 26, 2024

That looks similar (or a regression of) what I fixed in upstream MLIR commit llvm/llvm-project@1ef32e7

For constant ops from arithmetic constants, MLIR chooses SSA value names that reflect the constant. That failed for ints with > 64 bits as the function that derived that name used a shortcut that did not apply (and assert(), as here) for ints with more than 64 bits.

from qe-compiler.

mhillenbrand avatar mhillenbrand commented on May 26, 2024

My fix for upstream MLIR is not included in LLVM 14.0.6, yet we have backported to the branch of LLVM 14.0.6 that we use internally. That would explain why we see this in these CI runs - they use vanilla LLVM, right?!

from qe-compiler.

mhillenbrand avatar mhillenbrand commented on May 26, 2024

Two workarounds come to mind:

  • applying the fix as a patch to the build of LLVM in the CI
  • disabling the test (as expected to fail) until we have updated to LLVM 15 (which includes the fix).

from qe-compiler.

vrpascuzzi avatar vrpascuzzi commented on May 26, 2024

Thanks, @mhillenbrand. I'm a proponent of (1), applying the fix as part of the build--unless we're planning to have LLMV-15 sometime soon.

from qe-compiler.

taalexander avatar taalexander commented on May 26, 2024

These have now been set to expected failures may we close?

from qe-compiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.