Comments (11)
Hi @b2dac !
The described problem is the old bug in jqGrid. You can verify on the demo that it exists in jqGrid 4.6 and on the demo that it exists in jqGrid 4.7.
Nevertheless it's a bug and every bug should be fixed. I fixed it in my jqGrid fork. See the demo which uses the fixed code. If you will find the bug in the code please post the issue to my repository.
You can consider whether the usage of showSummaryOnHide: true
property of groupingView
displays information which you more prefer to see. See the next demo. It displays summary row below of the row with grouping header of the collapsed groups. In any way the choice of showSummaryOnHide: true
property is independent from the reported issue.
from jsgrid.
@OlegKi if you can't work with us then trying to get people to use your code from our repository isn't really acceptable.
from jsgrid.
Sorry @meh-uk , but I can't follow your logic. @b2dac wrote about the problem with summary (footer) of grouping. I answered him that it's not a bug which is specific for your fork. It's common problem in jqGrid. You didn't made any changes in jqGrid code, which follows the problem.
Moreover I'm trying to fix all bugs in jqGrid, which I find, and to share the solutions with other users of jqGrid. Do you have problem with it? Do you want to provide your own bug fix of the problem or you want to continue applying my fixes in your repository?
The most pity is that you didn't posted any answer to @b2dac . Do you plan to write your own answer to him?
from jsgrid.
I think, @OlegKi, that what disturb @meh-uk is you wrote : "I fixed it in my jqGrid fork" but you don't point the fix so we can fix it in this project.
So, if you come in THIS project issues, anwsering only your project is fixed and invite people to yours, sure it is not acceptable.
from jsgrid.
I was unaware of @OlegKi fork. That being said I am grateful that he told me about it. It's nice to have options.
from jsgrid.
I will leave this open so maybe it can get fixed.
from jsgrid.
Thanks! We will merge Oleg's fix shortly (we have to do some testing before since our codebases are not identical)
from jsgrid.
okay, thank you.
from jsgrid.
Thanks for fixing this. I'm still not sure which repo to go with, yours or @OlegKi . It's too bad you both can't merge the two.
from jsgrid.
That would be nice :(.
from jsgrid.
Oh believe me, we've tried for weeks. We've changed things on Oleg's request, discussed for hours on end, we've offered compromises on the things he didn't like, and even merged about 100 of his commits to make it easy for him to switch. But no such luck, all we got out of it were a string of merge errors that we're currently working through...
from jsgrid.
Related Issues (20)
- user definable footer summaries via drop down HOT 1
- setting the height property causes the horizontal scroll to unnecessarily appear HOT 3
- Clicking inline editing buttons should not remove selection HOT 16
- multiselect checkboxes not working properly HOT 1
- clicking form edit submit button does nothing when editurl and url are the same value
- form width in pager edit option not working HOT 14
- Edit option closeAfterEdit not functioning HOT 22
- Builder logs HOT 5
- grid not updating when editing HOT 39
- downloaded files naming in builder HOT 1
- Base in builder HOT 6
- use of grouping and loadonce:true causes subGrids to not work HOT 3
- New less organization HOT 29
- minifying css after (instead of) less HOT 2
- use JSDoc 3 for API documentation? HOT 1
- column alignment off when using group headers HOT 10
- Form Edit repopulate the entire table HOT 2
- What Is The Difference To free-jqgrid HOT 3
- one more jsgrid exist on GitHub HOT 2
- How to submit new row as JSON? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsgrid.