Git Product home page Git Product logo

Comments (10)

openmindculture avatar openmindculture commented on June 21, 2024
  • "all news" link not visible on iphone

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024
  • contact form:
    • clickable elements slightly too close together,
    • text might be slightly larger here, but not necessarily
    • submit button quite small on iPhone

contact form on iphone

  • sub-pixel artifacts distorting form fields in mobile Chrome on Google Pixel 6

contact form on Pixel Chrome

  • suboptimal auch auf Desktop Firefox:
    firefox contact form screenshot

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024
  • Footer links to imprint, TOS, and privacy pages too close together in Samsung Internet on Android
    footer on Samsung Android

But it's fine on iPhone

image

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024
  • heading line height insufficient (on TOS AGB page in Samsung Internet)
    image

same on iPhone:

image

and also on desktop if the viewport is small enough to force a line break.

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024
  • small paragraph text might be slightly too small to read comfortably on mobile
    • slightly increase font size?
    • slightly increase line height a little bit more?
    • slightly increase margins between offers list items

screenshot: Firefox on Huawei P30
offers on Android

  • similar but even worse due to sub pixel distortions on Google Pixel 7:

[image](screenshot: Chrome on Google Pixel 7)

  • offer sub navigation links might be slightly larger too

screenshot: Chrome on Google Pixel 7
image

Desktop

  • similar adjustments could be applied on desktop as well:
    • slightly larger line / height margin of list items
    • dto. especially between pricing lines

Vivaldi desktop browser screenshot

Actual websight (on the right) vs. Figma design (on the left):

figma design vs. desktop screenshot

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024

Desktop testimonial stories text goes below image base line for no reason, looks unintended or broken.

screenshot

vs. intended design
figma design screenshot section testimonial stories

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024

Auch wenn es so oder ähnlich entworfen wurde, erscheint es mir besonders auf kleinen Screens falsch, dass die Überschrift "Meine Mission" kleiner ist als "Gutscheine". Zumindest an dieser Stelle würde ich mir die Freiheit nehmen, weiter von den Designs abzuweichen, weil wir ohnehin noch unglücklich mit dem Bereich Mission / CTA waren.

Abstände reduzieren (s.o.) und Überschrift vergrößern:

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024

Schriftarten globaler korrigiert (1rem sollte auch mobil standardmäßig 16px bleiben).
Submit-Button durch Deaktivieren der Webkit-Appearance nun auch auf Apple iPhone wunschgemäß gestaltet.
Problematisch bleibt komische Schriftgröße auf Android u.a. bei den News-Überschriften (die könnten generell größer sein) und im Kontaktformular.

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024

Artefakte der Checkboxen könnten falscher Alarm, also ein scheinbares Problem sein, dass durch Zoom im BrowserStack-Interface entsteht. Scheint wahrscheinlich: zoom in und scroll hoch und runter verringert das Problem gegen Null.

from kleiderordnung-berlin.

openmindculture avatar openmindculture commented on June 21, 2024

Desktop testimonial stories text goes below image base line for no reason, looks unintended or broken.

screenshot

Hanging quote text only appears in production, not on localhost, so it's probably content related. Did the editor insert unintended additional paragraphs and we could we adapt our styles more generically - but that does not seem to be the reason. The new testimonial text by Cem is longer than the others, increasing common height.
Layout should not be affected by that. Can we make every other text align with the image baseline?
But if we introduce max-height and overflow, how to ensure that there is enough space below the testimonials?

Could we switch to more width instead of more height if a text gets too long?

screenshot with unexpectedly long text

Pragmatic improvements:

  • setting max-height (35.625rem like image height) restores the intended layout,
  • but overflow-y: visible has no visible effect, as the content overflows to the top, resulting in the quote symbols getting hidden at the upper container boundary. The same would happen to even longer texts.
  • Testimonials without an image might get additional width in any case.

.stories__story__image.empty + .stories__story__quote { width: 30rem (instead of 20) is not a generic solution, but a pragmatic workaround that might solve this specific problem and give the testimonial section a more individual, crafted look. It does in the case on the right, but it somehow deteriorates the shorter text-without-image case on the left:

screenshot helpful vs. unhelpful change

As we control our backend and we can analyze the CMS content, we can set an additional class name to restrict the fix to the actual problem, just like we already do when setting the empty class name.

CSS: .stories__story__image.empty + .stories__story__quote.long

PHP: if (strlen($current_content) > 360) { echo 'long'

Then it looks like this. We might probably have to refine this workaround and find a more generic solution, maybe revisiting this comment when (and not before) new testimonial content does not fit.

screenshot 2.9.15

from kleiderordnung-berlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.