Comments (21)
as much as I would like that, as long as M1 is not out of official support, I would see this as a BC break, as people could not "simply" switch over
from magento-lts.
Right, but my thoughts are that the people switching over to magento-lts would have a pretty good overlap with the people already using 5.6+ or that are capable of upgrading. This would open the door for officially supporting Galera cluster which would be pretty awesome. Or... we can keep supporting MySQL 4 just in case anyone out there is using it and wants to switch over. :-D
from magento-lts.
@alexkirsch The db adapter already supports 5.6 so no new code is necessary, it is just a project goal decision. The difference dropping old versions of MySQL is being able to get out of the 2000s and use useful new features that I already mentioned and support Galera cluster.
from magento-lts.
I wouldn't agree with fragmenting the project into multiple branches since resources are so limited. That is, I personally wouldn't bother committing improvements to anything but the master branch and I wouldn't expect others too either.
from magento-lts.
Agreed - especially since we're already using branches to support multiple minor versions. However, there might be room for creating a new minor version for BC breaks like this, which would follow whatever version "master" is in case Magento does at some point come out with another minor version for 1.*
from magento-lts.
+1 to what @colinmollenhour said. Guess we might have to wait until M1 is out of official support period.
from magento-lts.
With the focus of this project to be a Lts version of m1 I would recommend staying with the requirements of mainline. While I agree that maintaining MySQL 4.1+ is a little ludicrous it would be my vote to be 100℅ compatible with mainline for that drop in support.
from magento-lts.
Another option would be to add MySQL 5.6 or postgresql support as a separate db adapter.. but imho leave mysql4.
from magento-lts.
I would like to drop MySQL 4 support. Maybe we can create a new features branch / repo? And keep lts fixes in sync with the features branch /repo?
from magento-lts.
+1 to what @colinmollenhour said
from magento-lts.
+1 for dropping old MySQL support.
from magento-lts.
If you want to contribute it, I created the https://github.com/OpenMage/magento-ff repo as a branch which accepts BC breaking changes.
So I see now 3 choices.
- you contribute it to this new repo
- you wait till official magento support has ended, and there will not be a new magento version.
- one of the other maintainers accepts it as part of this repository
Why I am so hard with this:
people changing to LTS are most probably people who are not able to upgrade to Magento2 in less then 3 years. they are maybe also with other things more then 3 years behind. And especially MySql is one of the things people dont always update as long as it works, I have rarely seen Shops with one which was not at least 3 years old. Dropping Support for older then 5.5 may be ok, but also for 5.5 is an absolutely no
from magento-lts.
Thanks, but I already stated that I won't be contributing patches to more than one branch/repo/project. I understand the reasoning between having an LTS and a FF project separately, but I have very little time as it is and don't expect two separate such projects to be able to survive until Magento Inc lets go of M1, which I don't expect will happen for a long long time.
from magento-lts.
+1 for 5.6
from magento-lts.
Stay with the minimum requirements of M1? Take a look here: http://docs.magento.com/m1/ce/user_guide/magento/system-requirements.html
It says MySQL 5.6 and PHP 5.4. So no reason to maintain PHP <5.4 array-syntax for example anymore and start using MySQL 5.6 features. Colin, you have my +1.
from magento-lts.
+1 for MySQL 5.6
from magento-lts.
@Flyingmana and others, do you have customers still running on MySQL 5.5? Which are not willing to upgrade?
If Magento is officially stating that MySQL 5.6 is a requirement I personally would go for it.
But maybe we should start doing it in steps. First raise the requirement to 5.5 and adapt the code.
Then see what benefit do we have in moving to 5.6 ?
from magento-lts.
+1 for MySQL 5.6
from magento-lts.
Addressed in PR #507 (PHP 5.6-7.1 and MySQL 5.6+). PHP 7.2 should be supported after mcrypt issue addressed (different PR).
from magento-lts.
Time did fly, and I think smaller BC breaks are not an Issue anymore.
Also running something lower then MySQL 5.6 in times of general usage of SSDs is not recommended anyway.
So full support from me now to do this.
from magento-lts.
Maybe we can add this info to the readme (minimum requirements)
And in parallel list the maximum requirements (what is the latest version that is supported)
See #515
For instance I would not know right now what the latest mysql version is that I can use
from magento-lts.
Related Issues (20)
- Quote product prices rounding issues when catalog prices include taxes
- Upload gif image on backend system Configuration Issue HOT 2
- support smtp servers out of the box HOT 12
- In backend, add "click to copy text" feature HOT 1
- SOAP fault due to "SOAP-ERROR: Parsing Schema: can't import schema from 'http://schemas.xmlsoap.org/soap/encoding/' " HOT 25
- SOAP API: SOAP-ERROR: Parsing Schema: unexpected <complextype> in schema HOT 4
- Shopping Cart Price rule - Free Shipping weight condition
- feature request: Event for configuration actions (save/delete) on path HOT 2
- Admin filters and sorting not working after upgrader to v20.6.0 and v20.7.0 HOT 1
- Edit attributes broken? HOT 4
- Black background of PNG images with transparent background in the Wysiwyg editor HOT 11
- Skipped Zend_Validate_Barcode_Intelligentmail from autoloading HOT 1
- Improving the file name generation logic for JS and CSS files HOT 7
- After upgrade to v20.7.0 I got some alert on Admin Login HOT 16
- Fatal error after upgrading from 20.1.1 to 20.8 when clearing cache from Admin Page HOT 2
- Error when saving product with image without description HOT 6
- Problem with Configurable Swatches after PR #3686 HOT 1
- Unable to Override GroupController in OpenMage HOT 2
- N98-magerun tests fails since #2993 HOT 2
- Current category cache issue in navigation block
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento-lts.