[BUG] `make manager` changes source code of project about kruise HOT 9 CLOSED

I tried to fix the format and run the "make manager" command, in fact, it will reset to current format.
is this because of some kind of format setting ?

from kruise.

I tried to run the command, nothing changed.

$ make manager
go generate ./pkg/... ./cmd/...
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
go build -o bin/manager github.com/openkruise/kruise/cmd/manager
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

from kruise.

what is the go version on your machines? @allencloud @FillZpp

from kruise.

Go version on my machine go version go1.11.6 darwin/amd64.
Is your go version up to 1.12+ ? @allencloud

from kruise.

kruise (master) $ go version
go version go1.10.4 darwin/amd64
kruise (master) $

I am afraid it is only 1.10.4. Do we need a restriction that upgrade golang version to the 1.12+.
@xiang90 @FillZpp

from kruise.

can we add a go version check in the make script? @jian-he @FillZpp @allencloud

from kruise.

we could add a warning in the script.
failing it would hurt user experience, IMO.
And this looks to be a common problem for all Golang projects

from kruise.

Common users will not use make, they should install kruise using helm install or kubectl apply.
I think it is ok to return a failure of go-version check to kruise developers.

from kruise.

@xiang90 @jian-he @allencloud Add a go version check #54

from kruise.