Getting Started with Gradle: Avoid using internal APIs about openjfx-docs HOT 9 CLOSED

Google's ossdetector plugin is used by everyone building gRPC projects, with both Maven and Gradle. That's a sizeable chunk.

from openjfx-docs.

A possible solution would be to use https://github.com/google/osdetector-gradle-plugin from Google, which builds on top of https://github.com/trustin/os-maven-plugin.

This plugin resolves linux and windows as expected but uses osx for MacOSX. The JavaFX 11 artifacts expect mac, thus the minimum changes needed for it to work are

buildscript {
    repositories {
        maven { url 'https://plugins.gradle.org/m2/' }
    }

    dependencies {
        classpath 'com.google.gradle:osdetector-gradle-plugin:1.6.0'
    }
}

apply plugin: 'com.google.osdetector'

ext.platform = osdetector.os != 'osx' ? osdetector.os : 'mac'

Or alternatively since Gradle 2.1

plugins {
    id 'com.google.osdetector' version '1.6.0'
}

ext.platform = osdetector.os != 'osx' ? osdetector.os : 'mac'

Also, do not use script variables, prefer the usage of project variables, that is,

def platform = 'mac' // don't !!
project.ext.platform = 'mac' // :-)

from openjfx-docs.

Using a plugin to replace the internal API and the ugly if..else is definitely a +1

from openjfx-docs.

There is also org.gradle.nativeplatform.platform.OperatingSystem, which is however still incubating.

from openjfx-docs.

I like it!
Note that for gradle 2.1+ this is sufficient to apply the plugin:

plugins {
  id "com.google.osdetector" version "1.6.0"
}

from openjfx-docs.

My opinion is that having a dependency to a gradle plugin or a dependency to internal gradle API is the same. They are both pieces that are outside your direct control and that might break things in the future.

Having said that, the plugin dependency is an improvement here, just for the sake of readability. @aalmiray, it would be great if you can create a PR with your suggestions!

from openjfx-docs.

Use of a plugin for such a simple thing (at this stage anyway - with only three flavours to pick) seems like overkill. Specially if you have to massage the strings with additional conditions anyway ('osx' -> 'mac').
The use of the internal API in the first place is strange. The author should have known they were making mistake before they finished typing the line. Forgivable for your own private code perhaps, but when making it a public example - worthy of a few lashes. :-)

from openjfx-docs.

Fixed by #7.

from openjfx-docs.

Just got my hand on a windows machine. The plugin actually sets the platform as 'windows' instead of 'win'.

A viable solution would be to extend the condition:

ext.platform = osdetector.os == 'osx' ? 'mac' : osdetector.os == 'windows' ? 'win' : osdetector.os

I am writing it here in case someone has a better approach.

from openjfx-docs.