opening-hours / opening_hours.js Goto Github PK

For example "Pon-Cz 12:00-22:00;Pt-So 12:00-13:00;N 12:00-22:00" is relatively easy detectable as Polish rather than German, but currently "so" is changed because it fits German shortcut.

Upgrade of #10

See: https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/Time_domains#Existing_implementation

Give at least a warning if no time selector is present in a rule which evaluates to open.

Demo use "minute" and "hour" for 1 and "minute_plural" and "hour_plural" for more then 1. But not use "minute_many" and "hour_many".
Откроется завтра, 7 Апреля, через 16 часа and 35 минуты. It's wrong.
Correct is Откроется завтра, 7 Апреля, через 16 часов and 35 минут.
In i18next code:
"ru": {
"name": "Russian",
"numbers": [
1,
2,
5
],
"plurals": function(n) { return Number(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2); }
},
return 0, 1 and 2.
But it's not using.
Program calculate
"plurals": function(n) { return Number(n > 1); }

It would be nice to support the creation of opening hours strings (for example as in the JOSM plugin).

http://wiki.openstreetmap.org/wiki/Key:opening_hours:specification#rule8

When doing a lookup of a location in a country where the country code is not the same as the language code for that country, state names may be presented in a non-local language.

As an example on demo page:

Latitude: 55
Longitude: -82
country: ca
state: Ontàrio

Country 'ca' should instead be mapped to 'en,fr', which should display state: Ontario

There is a list of Country Codes on the wiki, but I am not aware of an API or OSM library that does conversions/lookups.

Hi,
I wanted to test the evaluation tools mentioned on the main page of your project. But the link is down. Do you know reasons of that problem?

Thank's

Isn't "," should keep the day so off should only apply to Mo-Fr?

Most of the weekday names and abbreviations are unique over the different languages. But there are some with the same name, but different meanings. See #10.

Try to auto detect the language and use this for names which have multiple meanings. This feature has very less priority because it’s implementation afford is high in contrast of it’s probable use.

From josm-dev:
https://lists.openstreetmap.org/pipermail/josm-dev/2013-December/006816.html

It appears the current supported seasons (winter/summer) do not satisfy everyone :)

"spring" and "autumn" should maybe be supported as well ?

See https://github.com/ypid/opening_hours_map/issues/14
Will be added next week 😄

Dunno about im right here with that:

following way: https://www.openstreetmap.org/way/125170567 (not changed by me)
Mo-Fr 05:00-21:00; Sa;Su 07:00-21:00; PH 07:00-21:00

opening_hours (in the qat-script) found right warning, josm-check not.

German:
Keine Ahnung, ob ich hier richtig bin.
Gerade obiges mit dem opening_hours-qat-script reingeholt, ich mache zusätzlich eine Josm-prüfung. Diese gibt mir keine Warnung aus. Sollte aber meines Erachtens (obwohl die Regel formal korrekt ist)

Mo-Fr 07:00-19:30; Sa-Su 08:00-19:30; 19:30-21:00 open "No new laundry loads in"; Nov Th[4] off; Dec 25 off

This evaluates on http://openingh.openstreetmap.de/evaluation_tool/ , if you look at December 25, 20:25:

Facility is now closed, comment: "No new laundry loads in"
but will close today, 25 December, in 35 minutes.

Expected result would be:
Facility is now closed.

Evaluation shouldn't return a comment from an 'Open' string when the facility is ultimately closed, nor indicate that the facility 'will close soon', because it already is.

See <separator_for_readability>.

http://openingh.openstreetmap.de/evaluation_tool/?EXP=Apr-Sep%3B%20Oct-Dec%20%22on%20request%22&DATE=1381953480000

and
http://openingh.openstreetmap.de/evaluation_tool/?EXP=11%3A00%2B%3B%20Oct%201-Apr%2030%20Mo%20off%3B%20Nov%201-Mar%2031%20Mo%2CTu%20off&DATE=1366717140000&lat=48.7769&lon=9.1844&mode=0

found at https://github.com/ypid/opening_hours.js/blob/1e5a866cb7dd628085899f585554b0aa54280a4d/opening_hours.js

http://openingh.openstreetmap.de/evaluation_tool/

Not seems to work.

Use colors for this.

Feb 2-Oct 15 09:00-18:30; Oct 16-Nov 15 09:00-17:30; Nov 16-Feb 15 09:00-16:30
When is the feature open on the Feb 10th? Till 18:30 or 16:30?
Thank you for this amazing code :-)

Real world example: http://www.openstreetmap.org/browse/node/1994157720 "opening_hours = Pon-Cz 12:00-22:00;Pt-So 12:00-13:00;N 12:00-22:00"

Translation should probably be used as last resort.

Translation from Polish to English:

poniedziałek, poniedzialek, pon, pn -> Mo
wtorek, wt -> Tu
środa, sroda, śr, sr -> We
czwartek, czw, cz -> Th
piątek, piatek, pt -> Fr
sobota, sob, so -> Sa
niedziela, niedz, N, ndz -> Su

In addition - shorter forms may be suffixed with . sign

http://robin.de.marissa.hostorama.ch/osm/opening_hours.js/demo.html?EXP=Mo-Fr%2010%3A00-20%3A00%20%22testing%22%3B%20&DATE=1381869960000

Infinite loop.

Problem is in drawTable?

Probably it should be mentioned that prettification did something (like it is done in other similar situations)

Is this bug also affecting this fork or did you already fix this problem?

I did an npm install after checkout the repository and it seems the moment-with-langs.min.js is not pulled.

Do you know how to fix this in your setup ?

First click is required to change focus. With second click the content is updated. Tried already to solve this …

sorry for using Bugtracker as request forum ;)

May,Sep Mo 21:00+; [...]

is the correct (OH-map says) rule for

Mondays in May and Mondays in September

but i don't understand that, my head wants to render:

May all days, Sep only Mo.

Who is wrong?

Prettifier is unable to recognise it as Sa 7:00-13:30.

"Sa 7-13" is recognised as "Sa 7:00-13:00" with comment

(Time range without minutes specified. Not very explicit! Please use this syntax instead e.g. "12:00-14:00".)

(EDIT: I encountered it in real OSM data, in edit https://www.openstreetmap.org/changeset/28047201 I fixed tag that had this problem).

Also for week 4-16.

Hi,
We have a bug with JOSM if we validate opening_hours=SH offwith Java 8:
https://josm.openstreetmap.de/ticket/10423

The bug does not occur with Java 7. I suspected a Java 8 regression but after further investigation I think this a "feature". Java 8 introduced a new JavaScript engine, called Nashorn:

http://docs.oracle.com/javase/8/docs/technotes/guides/scripting/

It is a strict implementation of ECMAScript Edition 5.1 and does not include any feature appeared with ECMAScript 6.

The bug occurs with this instruction:

return [ true, new Date(date.getFullYear() + holiday_ends_next_year, holiday[2+h] - 1, holiday[3+h] + 1),
    applying_holidays[i].name ];

I believe the nameproperty is new with ECMAScript 6:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name

and that would make Nashorn fail. Is it possible to not use this property and stay strictly compliant to ECMAScript 5.1 ?

Problem occurs with Firefox and Chromium.

see: http://openingh.openstreetmap.de/evaluation_tool/?EXP=11:00-20:00%20au%C3%9Fer%20Mo

(sollte besser umgedreht werden)

http://wiki.openstreetmap.org/wiki/Proposed_features/opening_hours_open_end_fixed_time_extension

As suggested by AMDmi3 a long time ago.

There are quite some holiday modules already on npm. I will have to check them out and see which ones can be reused.

This is also intended to allow holiday definitions of arbitrary complexity. See Russian holidays and US holidays. And to allow other projects to reuse the handy list of public/school holidays which this library has collected by now.

• Review other npm packages and add refs to readme or check if a package already exists which uses a similar format than opening_hours.js and discuss if projects can/should merge.
• Create package.json below holidays.
• Compile legacy JS file with rollup below holidays.
• Write readme how the holidays can be used standalone (ES6, and legacy JavaScript) (importing and accessing should be enough. Users will need to figure out how to evaluated them on their one).
• Publish to npm. @ypid would like to do this to stay in control of the holidays.

Missing public holidays for United States. http://www.opm.gov/policy-data-oversight/snow-dismissal-procedures/federal-holidays/#url=2015

Hi!

Have you thought about using Moment.js for date localization. I think it is better to use some library than to translate months and dates for each language. License is MIT which I think is compatible with BSD.

"Please have a look at the [evaluation tool][] which can give you an impression how this library can be used and what it is capable of." - in general, search for []