Git Product home page Git Product logo

Comments (3)

djboersma avatar djboersma commented on July 21, 2024

The include of the itkThirdParty.h got re-enabled in commit 071dd73. It looks like something is missing in the cmake configuration of the source/externals/itk-mhd directory.

Maybe DavidS and/or Simon Rit did an incomplete commit/merge?
If the answer to that is negative: I am currently testing this patch below.

diff --git a/source/externals/itk-mhd/CMakeLists.txt b/source/externals/itk-mhd/CMakeLists.txt
index c8b0a8a..c070b92 100644
--- a/source/externals/itk-mhd/CMakeLists.txt
+++ b/source/externals/itk-mhd/CMakeLists.txt
@@ -11,6 +11,7 @@ SET(ITK_INSTALL_NO_DEVELOPMENT ON)
 INCLUDE_DIRECTORIES(${PROJECT_SOURCE_DIR} ${PROJECT_SOURCE_DIR}/src ${PROJECT_BINARY_DIR})
 SUBDIRS(itkzlib)
 ADD_SUBDIRECTORY(src)
+INCLUDE(itkThirdParty.cmake)
 # ADD_EXECUTABLE(testmhd testmhd.cxx)
 # TARGET_LINK_LIBRARIES(testmhd ITKMetaIO itkzlib)

diff --git a/source/externals/itk-mhd/itkThirdParty.cmake b/source/externals/itk-mhd/itkThirdParty.cmake
index 3fafc6a..caa88c0 100644
--- a/source/externals/itk-mhd/itkThirdParty.cmake
+++ b/source/externals/itk-mhd/itkThirdParty.cmake
@@ -55,3 +55,7 @@ MACRO(ITK_THIRD_PARTY_SUBDIR upper lower)
     SUBDIRS(${lower})
   ENDIF(NOT ITK_USE_SYSTEM_${upper})
 ENDMACRO(ITK_THIRD_PARTY_SUBDIR)
+
+configure_file(${CMAKE_CURRENT_SOURCE_DIR}/itkThirdParty.h.in
+               ${CMAKE_CURRENT_BINARY_DIR}/itkThirdParty.h )
+include_directories(${CMAKE_CURRENT_BINARY_DIR})

It looks like at least it compiles again with USE_ITK=OFF. Need to check that it also still compiles & runs with USE_ITK=ON. If I do not encounter any bad crashes then I might be able to submit a pull request later this afternoon to fix this.

from gate.

djboersma avatar djboersma commented on July 21, 2024

Looks like the above fix works for me, but I did only very minimal testing. See pull request.

from gate.

dsarrut avatar dsarrut commented on July 21, 2024

Seems to work for me, either ITK=OFF and ON. Thanks !

from gate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.