Add babel to the build process about richie HOT 5 CLOSED

If I understand well, it means that we will have two consecutive code transpilation phases (TS+babel). Don't you think this will make debugging rather complex? Does it worth it? Is this the way to go with TS?

from richie.

Don't you think this will make debugging rather complex?

Source maps are working. Do you have other concerns? How would it make debugging more complex than with just TS?

Is it worth it? Is this the way to go with TS?

I think it is. Tooling for i18n string extraction is pretty thin on the ground, so if we have a simple, working, automated solution it's definitely worth adding a little bit of complexity to the build config IMO.

from richie.

Source maps are working.

I may have misunderstood how a second loader (i.e. babel) will work: source maps from TS will be generated from the TS loader, and then babel will generate (or overwrite) a new source maps version from compiled TS?

In this case, a babel-related bugs may be hard to track. I might be wrong on this, please enlighten me.

from richie.

Source maps mean errors, logs, etc. get associated with the actual call site in the TypeScript source. Babel does generate new source maps based on the ones TS generated (otherwise we could not associate the final code to the actual source).

In this case, babel-related bugs may be hard to track

Because the ES6 babel compiles from is an intermediate representation that does not get written to disk? Indeed, you would have to output the ES6 itself from typescript to take a look at it.

However, I would argue that such bugs would be a rare occurence. Babel is mature (more so than TS I'd say) and I would be amazed if we actually ran into a bug in it when compiling vanilla ES6. Combining TS & babel is not exotic and mostly works out of the box.

Bugs in our own code (or regular deps) which would constitute >99% of debugging work will be straightforward to pinpoint with source maps.

from richie.

Thanks for this explanation. I put my trust in you. Let's do this!

from richie.