Git Product home page Git Product logo

Comments (9)

Daandelange avatar Daandelange commented on August 12, 2024

yes it was in the console, looks like it's been stripped out. Shall I put that back ?

from projectgenerator.

ofZach avatar ofZach commented on August 12, 2024

yeah I think it's a good idea to put it back in, so we can debug easier any problems.

from projectgenerator.

Daandelange avatar Daandelange commented on August 12, 2024

There you go, with a readme entry and I also put back my last forgotten commit from ofZach/pgElectron

from projectgenerator.

ofZach avatar ofZach commented on August 12, 2024

thanks ! I don't think we need it in an ever present console -- just to be reported on the console you see with success / failure dialog...

from projectgenerator.

Daandelange avatar Daandelange commented on August 12, 2024

It's pretty discreet like this and I find it useful useful to trace back generated projects and, as you said, look at their command line string. What about simplifying/shortening it so that you only see the command history, clicking on each of them them will show their console output.

The verbose mode setting already defines if we see the success modal with a console (btw, this setting does nothing for the moment... and is not present in the default settings.json)

So I see the verbose option more as a project related setting while the showConsole setting is related to all projects.

from projectgenerator.

ofZach avatar ofZach commented on August 12, 2024

no I'm sorry we already decided not to have this console. we already have 3 potential console outputs

a) the console output if you run electron from the command line (ie npm start)
b) the console output if you run developer tools
c) the console output from success / failure on generate project.

I really don't think we need a 4th and I think this just confuses things to have this user facing. all I am asking for here is to always put the command line string that we are firing off the command line tool in the console output of (c). We could improve the reporting in (a / b) if it feels like we need to give better feedback. thanks!

from projectgenerator.

ofZach avatar ofZach commented on August 12, 2024

(ps this is where we decided not to have this additional console ofZach/pgElectron#24 (comment))

from projectgenerator.

Daandelange avatar Daandelange commented on August 12, 2024

Ok, that sounds good! Sorry for the confusion...
In fact i saw the showConsole as a hidden setting but by cleaning up the other consoles it's enough too. 👍

I added some commits removing the old console code and adding support for verbose option.

from projectgenerator.

ofZach avatar ofZach commented on August 12, 2024

I've added this now -- closing this issue

from projectgenerator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.