Git Product home page Git Product logo

Comments (4)

yspolyakov avatar yspolyakov commented on June 7, 2024

I was able to recreate the error. Here is an example.

[ 46%] Building CXX object src/binfhe/CMakeFiles/boolean-serial-json.dir/examples/boolean-serial-json.cpp.obj
In file included from C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest.h:376,
                 from C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp:37:
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp: In member function 'virtual void UnitTestFHEWGINX_EvalArbFunc_Test::TestBody()':
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp:69:19: error: 'uint' was not declared in this scope; did you mean 'usint'?
   69 |         EXPECT_EQ(uint(fp(i, p).ConvertToInt()), result) << failed;
      |                   ^~~~
C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'
   77 |   if (const ::testing::AssertionResult gtest_ar = (expression)) \
      |                                                    ^~~~~~~~~~
C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest_pred_impl.h:164:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'
  164 |   GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
      |   ^~~~~~~~~~~~~~~~~~~
C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest.h:2028:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'
 2028 |   EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
      |   ^~~~~~~~~~~~~~~~~~~
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp:69:9: note: in expansion of macro 'EXPECT_EQ'
   69 |         EXPECT_EQ(uint(fp(i, p).ConvertToInt()), result) << failed;
      |         ^~~~~~~~~
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp: In member function 'virtual void UnitTestFHEWGINX_EvalFloorFunc_Test::TestBody()':
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp:95:19: error: 'uint' was not declared in this scope; did you mean 'usint'?
   95 |         EXPECT_EQ(uint(i / 2), result) << failed;
      |                   ^~~~
C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'
   77 |   if (const ::testing::AssertionResult gtest_ar = (expression)) \
      |                                                    ^~~~~~~~~~
C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest_pred_impl.h:164:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'
  164 |   GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
      |   ^~~~~~~~~~~~~~~~~~~
C:/git/openfhe-development/third-party/google-test/googletest/include/gtest/gtest.h:2028:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'
 2028 |   EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
      |   ^~~~~~~~~~~~~~~~~~~
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp:95:9: note: in expansion of macro 'EXPECT_EQ'
   95 |         EXPECT_EQ(uint(i / 2), result) << failed;
      |         ^~~~~~~~~
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp: In member function 'virtual void UnitTestFHEWGINX_EvalSignFuncTime_Test::TestBody()':
C:/git/openfhe-development/src/binfhe/unittest/UnitTestFunc.cpp:118:19: error: 'uint' was not declared in this scope; did you mean 'usint'?
  118 |         EXPECT_EQ(uint(i >= 3), result) << failed;

from openfhe-development.

dsuponitskiy avatar dsuponitskiy commented on June 7, 2024

from openfhe-development.

dsuponitskiy avatar dsuponitskiy commented on June 7, 2024

After having fixed the original errors, I found another issue: MinGW crashed for CKKS bootstrapping. The root cause of it is related to parallelizing a loop with OMP. It looks like an OMP bug that can be seen on MinGW only. The best option to fix this bug is not to use OMP for that particular loop on MinGW. This was discussed with @yspolyakov who doesn't think that this change should have a sizable effect on performance.

from openfhe-development.

yspolyakov avatar yspolyakov commented on June 7, 2024

Yes, the same crash (segfault) in CKKS bootstrapping was observed in https://openfhe.discourse.group/t/open-fhe-building-error-in-windows-10/117/8

from openfhe-development.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.