Comments (5)
@cgoldberg tagging you also for any thoughts/input you might have on this one.
from bok-choy.
I'm not sure what the desired semantics were. I can see arguments on both sides, but the doc says, "will poll until either A, B, C", which makes it sound like it was supposed to stop after the default 30 seconds even if the number of tries hadn't been reached. Perhaps the simplest thing to do is to add some clarifying text to the docstring.
from bok-choy.
For me the confusion was in the default timeout of 30s, and how selenium also uses a 30s timeout when trying to instantiate the browser. So I just happened upon a fun and special situation last week since I was working on the Promise that deals with starting the browser itself.
Back to your question though, if we go with an either/or, my concern would be for try_limits that get hung...there would be no default timeout that stops the test.
from bok-choy.
oh, that's right @benpatterson
Now I remember why we did that, so you wouldn't hang yourself accidentally.
@nedbat I like your idea about a better docstring.
I think that's what we should do. I'll put in a PR when I get a chance.
Thanks guys for helping to think this through. 👍
from bok-choy.
Addressed in #167
from bok-choy.
Related Issues (19)
- Docs: Tutorial test does not pass HOT 1
- Add Python 3 compatibility HOT 4
- Update FirefoxDriver usage to GeckoDriver/Marionette HOT 7
- Package wheels and distribute on pypi HOT 1
- Deprecate HAR capture HOT 1
- @property in Docs
- Make better use of pylint HOT 1
- Screenshots
- Provide means to pass additional desired capabilities to remote driver
- Importing ABC directly from collections was deprecated and will be removed in Python 3.10. Use collections.abc
- Add Support for Query Chaining HOT 4
- Add a promise for element_to_be_clickable in the BrowserQuery's click method HOT 1
- Tutorial part 2 is broken HOT 1
- Update Selenium HOT 1
- Add Support for Authentication in URLs
- PDF builds at readthedocs are failing
- The tutorial needs to be updated to reflect changes in the GitHub UI. HOT 1
- Add html source file of failed test along with screenshot in reports
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bok-choy.