Comments (4)
Restarting the zfs-node daemonset is must, so that driver can pick up the required topologies if they are added after driver is installed. One way is that while installing we can set topologies so that later on for those keys we don't need to restart node-agents. see here -- https://github.com/openebs/zfs-localpv/blob/develop/docs/faq.md#6-how-to-add-custom-topology-key
For rebooting the node, it should not be the behaviour and I myself has come across rebooting the node scenario's. Volume provisioning worked fine for me. Can you please share your storage class yaml and kubectl get csinode <node-name> -o yaml
and verify that same key which is used in storage class is present on the node
from zfs-localpv.
Can you please share your storage class yaml
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
creationTimestamp: "2024-04-16T22:33:59Z"
name: openebs-zfspv
resourceVersion: "1294905"
uid: e45d8212-7b24-481c-88ea-194ee5a27f21
parameters:
compression: "off"
dedup: "off"
fstype: zfs
poolname: zfspv-pool
recordsize: 128k
provisioner: zfs.csi.openebs.io
reclaimPolicy: Delete
volumeBindingMode: Immediate
kubectl get csinode -o yaml
See gist here
and verify that same key which is used in storage class is present on the node
Do you mean compare CSINode
with node labels? Node labels are here
I restarted openebs-zfs-localpv-node
daemonset then compared CSINode
topologyKeys
after restart with the values before restart and can see only this value has changed:
< - scheduling.node.kubevirt.io/tsc-frequency-2200000000
---
> - scheduling.node.kubevirt.io/tsc-frequency-2199997000
from zfs-localpv.
I understand the issue is caused by the topology keys in CSINode
not matching the node labels after a reboot. This can be fixed by updating the openebs-zfs-localpv-node
daemonset and setting ALLOWED_TOPOLOGIES
from all
to a list of specific labels that I know won't change on reboot.
It seems odd that Kubevirt uses a node label with a dynamic key value, but I guess there must be a good reason.
I appreciate the need for the topology keys to match the node etc, but I wonder if there is a better default approach for zfs-localpv
that will permit it to work with Kubevirt (and operators like it) 'out of the box' (i.e. without needing special configuration)?
from zfs-localpv.
hi @ianb-mp
As @w3aman said you can use this doc https://github.com/openebs/zfs-localpv/blob/develop/docs/faq.md#6-how-to-add-custom-topology-key to add the custom label.
As i can understand in your case the kubervirt has dynamic label which changes upon node restart. The new label need to be updated in the daemonSet directly by editing it and then restarting.
The default is specified as al
l, which will take the node label keys as allowed topologies. This you can change it by editing the daemonset.
Now in your case the node labels change upon restart, which should not have happened.
And if the node label changes then you need to update the daemon set and restart it to reflect the change
from zfs-localpv.
Related Issues (20)
- feature: zvol as block volume without attaching to a pod HOT 7
- Erroneous release v2.4.1 HOT 4
- Default values are of the wrong type
- Volumes are not removed after PV is deleted with Delete reclaimPolicy HOT 7
- Backup exit 1 when ZFSbackup HOT 2
- velero plugin maintenance HOT 5
- URGENT: Helm chart for 2.5.0 deletes VolumeSnapshot CRDs - including all snapshots HOT 12
- Feature request: human-readeable names of volumes (with namespacing) HOT 2
- Latest operator yaml installs version 2.4.0 instead of the latest one HOT 7
- Not working with k0s HOT 4
- [Clone from Snapshot] CloneCommand never send HOT 34
- Block mode volumes created as filesystems HOT 1
- Avoid pushing an image to the container registries, when a branch is created on this repo
- Refactor the zfs localpv product logging and error propagation
- Volume From Snapshot Fails With Custom Node Ids HOT 3
- Incorrect documentation repo URL in the PR template
- localpv-node hangs in CreateContainerError on talos HOT 1
- Microk8s - MountVolume.SetUp failed HOT 1
- Cannot import existing ZVOL with XFS file system HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zfs-localpv.