Git Product home page Git Product logo

Comments (3)

anthonyfok avatar anthonyfok commented on September 2, 2024

Hey @tieganh,

Regarding renaming, I think it is a great idea, even though it does require careful planning and potentially non-trivial amount of work, and would likely involve @drotheram and @wkhchow too. To What types and scope/extent do you have in mind?

Name type(s) to rename

First, in my limited understanding, there are two types of names:

  1. Display name, e.g. "M4.9 Georgia Strait (BC)"
  2. Code name (I am probably calling it wrong, please correct me) seen in file names, path names, in initialization files, in code, etc., e.g. ACM4p9_Capilano5

Changing the display names alone is relatively simple, though there will be difficult for the users to match the display name to the corresponding code name.
Changing the code names too would be quite a bit more involved, but hopefully creates consistency and avoids confusion in the long run.

Scope/extent of the rename

From my limited understanding, here are the steps that are involved roughly from beginning to end (rough chronological order):

Some of the above would propagate automatically; some would require manual changes.

Other concerns

Since the renaming will involve quite some work, we should get it right the very first time, and to fix any related issues on the way.

Consistency in naming and with description

I'm probably, as the Chinese saying "雞蛋裏挑骨頭" goes, "picking bones out of an egg" (i.e. nitpicking), but here are some examples of inconsistencies that I came across:

  • "M5.5 near Ottawa (ON)" vs "M5.0 event near Montréal (QC)": Is there a difference in these two scenarios such that one uses the word "event" but the other doesn't?

  • https://geo-api.riskprofiler.ca/collections/opendrr_dsra_acm4p9_capilano5_indicators_b shows "Capilano 4.9 Scenario (Point)" in the title but "Scenario for a magnitude 5.3 shallow crustal earthquake..." in the description.

  • FINISHED/SIM9p0_CascadiaInterfaceBestFault.md in the public OpenDRR/earthquake-scenarios repo still refer to files in the private OpenDRR/openquake-inputs repo, and apparently with "incorrect" paths. (Probably correct on a local system where all the repos are checked out, but not on the web?)

Documentation

There should also be a mapping table maintained somewhere that document these changes, especially the old names have been "out there" for some time now, and to have a "canonical source" for all of us to refer to. Here is an example:

(Proposed) Code name change (Proposed) Display name change
ACM4p9_Capilano5
ACM4p9_GeorgiaStraitBC (or just ACM4p9_GeorgiaStrait?)
Capilano5 →
M4.9 Georgia Strait (BC)
ACM7p0_GeorgiaStrait
ACM7p0_GeorgiaStraitBC
Georgia Strait →
M7.0 Georgia Strait (BC)
... ...
SIM9p0_CascadiaInterfaceBestFault
SIM9p0_CascadiaFullRuptureSubductionEarthquakeBC
Cascadia Interface Best Fault →
M9.0 Cascadia Full Rupture Subduction Earthquake (BC)

OpenDRR/earthquake-scenarios

With the upcoming influx of over 50 new earthquake scenarios, some in our tech team wonder if the flat structure of the FINISHED and initialization directories is the best way forward. If we are doing mass renaming anyway, it would be a great opportunity to do a directory restructure too, e.g. by putting the multiple files of each scenario in their own directory, if we indeed come to a consensus to do so.


That's my 2 cents. 😁

So yes, let's continue our discussion here on GitHub and on Zoom to see how and when we want to proceed, e.g. to try to have the upcoming v1.4.4 data file updates, or for a later date, etc. Fun! 😄

from earthquake-scenarios.

DamonU2 avatar DamonU2 commented on September 2, 2024

As @anthonyfok said, this is bigger issue than it seems. Specifically, for GitHub pages, the "code name" is used to generate the "display name", as it was set up to add additional scenarios with limited manual updating. All of the links, tiles, and associated files use the "code name" for ID, so we'd have to change the "display name" down the line.

The easiest way to do this is probably to add a "display_name" variable to the initialization files, and pull that in. However, we then have the issue of someone looking at a scenario named "Georgia Strait 4.9" and downloading a file called "capilano5", and probably assuming the link is broken (side note - should Georgia Strait be Salish Sea?). This is probably a good method if the code name and display name are similar, ex. "Ottawa" to "near Ottawa", and we just want additional detail, but seems problematic otherwise, ex. "BurwashLanding" to "Denali Fault".

The best way going forward may be to add a display name variable, but also to rename the files in the case of big changes, and reprocess them. @tieganh Do we have a list of proper names for the scenarios in Jeremy's repo?

from earthquake-scenarios.

wkhchow avatar wkhchow commented on September 2, 2024

Can only comment for the db side of things. The indicators_b, _s, _csd for the earthquake scenarios are generated off the code names. There is also reference to the code name in 'sH_RupName' indicator. In the long run it would be best to rename the code names at source to run the scenarios.

Quick fix in the meantime if needed I can go into the DB and manually update and adjust if needed, and generate the geopackages.

from earthquake-scenarios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.