Git Product home page Git Product logo

Comments (4)

linusmartensson avatar linusmartensson commented on August 27, 2024

Wanted to reference OpenDroneMap/ODM#1074 here, since this may be the same issue.
The sanitizing in NodeODM seems unnecessary since the rest of ODM works without it. In addition to the above issue, I found it causes errors when using exif files sent from a master odm instance running with --sm-cluster, and any use of the feature and match data being transferred back will also have sanitized filenames that won't match filenames in the master node.

I would think this has been missed since the two most common use cases with WebODM and CloudODM both transfer data to NodeODM at the start of processing, ensuring all filenames are mangled from the start (except GCP entries)

from nodeodm.

pierotofy avatar pierotofy commented on August 27, 2024

Sorry for the late reply, mm, I think you're right, special characters should work OK in ODM (?) and I think this was implemented to originally fix the common issue of spaces in filenames, but since ODM handles those now, this is probably no longer needed.

from nodeodm.

pierotofy avatar pierotofy commented on August 27, 2024

Commit referencing sanitization: cbf5e40

from nodeodm.

pierotofy avatar pierotofy commented on August 27, 2024

Removed sanitization in latest master. This can be closed.

from nodeodm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.