Unexpected behavior when double/triple/N clicking a file in the MPQ Explorer about hellspawner HOT 3 CLOSED

After investigation it looks like the culprit of the bug is the management of the editorManagerMutex https://github.com/OpenDiablo2/HellSpawner/blob/master/hsapp/app.go#L222

The issue appears to be on fast machines, multiple openEditor calls will fire and process such that concurrent executions of the createEditor method reach the lock on L222. This leads to the a.editors list containing multiple entries with the same unique ID.

from hellspawner.

My proposed change is to move the lock acquire from L222 to the beginning of CreateEditor. This will enforce that only one createEditor call will be fired for any given Unique ID. The RLock in the openEditor method will no longer be acquired when a concurrent execution of CreateEditor is generating the editor as opposed to the current behavior where the RLock gets acquired allowing multiple CreateEditors to reach the a.editors = append... line on 224

Edit: This causes the RestoreApp functionality to become laggy as it has to wait to generate each editor object

from hellspawner.

I think your proposed solution is good enough, I don't think it's a big deal for there to be some reasonable delays during app start. A "reasonable" delay would be ~2 second startup for an existing project with some editors opened.

from hellspawner.