ONLP onlp_sfp_eeprom_read shifts QSFP EEPROM data about opennetworklinux HOT 3 CLOSED

Found it:

https://github.com/opencomputeproject/OpenNetworkLinux/blob/master/packages/platforms/accton/x86-64/x86-64-accton-wedge100bf-32x/onlp/builds/src/module/src/sfpi.c

Lines 172 – 182.

For (i=0;  i < 128; i++0) {
     Int bus = sfp_bus_index(port);
     Int val = onlp_i2c_readw(bus, devadr, i*2, ONLP_I2C_F_FORCE);

     If (val < 0) {
           return ONLP_STATUS_E_INTERNAL;
     }

     data[i] = val &0xFF;
     data[i+1] = (val >>8) &0xFF;
}

They read a two-byte word from Transceiver EEPROM then move data to the read buffer which is uint8_t data[256];
Each step of the loop they write 2 bytes to the buffer overwriting second byte just written on the previous step.

Needs to be modified as:

       data[i*2]  = val &0xFF;
       data[(i*2)+1] = (val >>8) &0xFF;

from opennetworklinux.

Replaced data[i] and data[i+1] with data[i2] and data[(i2)+1] respectively in sfpi.c file. After replacing, connected the innolight transceiver to Accton Wedge100BF_32x SFP port to read the SFP EEPROM and data can be read correctly. Also same innolight transceiver was connected to AS7312_54XS device for testing and both Accton Wedge100BF_32x SFP EEPROM data and AS7312_54XS SFP EEPROM data are same except some real time data.

from opennetworklinux.

With that fix function works. Transceiver EEPROM is read properly.

from opennetworklinux.