Comments (6)
@XhmikosR This sounds similar to #524
I guess you're talking about https://github.com/opencollective/frontend/tree/master/src/public/svg
In which files do you see any base64 encoding?
from opencollective-frontend.
Not related. This is for the SVGs that include a base64 PNG. The other issue is for base64 encoding the whole SVGs.
An example is https://github.com/opencollective/frontend/blob/35f52ebde057bd80e4a65331c4748e14da57d6e4/src/static/images/organization.svg
More results in https://github.com/opencollective/frontend/search?q=base64&unscoped_q=base64
from opencollective-frontend.
I agree, the example you provided organization.svg
should be a pure svg and not contain any base64.
from opencollective-frontend.
There are many more, just look at the codebase :)
from opencollective-frontend.
For the SVGs in the static folder, if you have a solution, feel free to submit a PR and provide the command to do it. I don't think that needs to be in the build process now, fixing the files in the repository should be enough.
from opencollective-frontend.
No, this needs to be done manually because the PNGs that are in the SVGs serve a purpose visually :P
from opencollective-frontend.
Related Issues (20)
- An in-range update of eslint-plugin-react is breaking the build 🚨 HOT 1
- Problem with large user-icon HOT 2
- Labeling existing issues and new issues HOT 1
- To report or browse Issues, use our main repository
- An in-range update of enzyme is breaking the build 🚨
- An in-range update of enzyme is breaking the build 🚨
- An in-range update of enzyme is breaking the build 🚨
- An in-range update of webpack-bundle-analyzer is breaking the build 🚨
- An in-range update of lint-staged is breaking the build 🚨 HOT 1
- An in-range update of eslint is breaking the build 🚨 HOT 1
- An in-range update of enzyme is breaking the build 🚨
- An in-range update of eslint is breaking the build 🚨 HOT 1
- An in-range update of sinon is breaking the build 🚨 HOT 1
- An in-range update of eslint is breaking the build 🚨 HOT 1
- An in-range update of enzyme is breaking the build 🚨
- Typos present in project.
- Pledge amounts a11y issue/clarity HOT 2
- RSS/Atom feed for Updates HOT 2
- Dependency Dashboard
- https://interactive-card-details-form-three.vercel.app/success.html?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opencollective-frontend.