Git Product home page Git Product logo

Comments (6)

znarf avatar znarf commented on August 20, 2024

@XhmikosR This sounds similar to #524

I guess you're talking about https://github.com/opencollective/frontend/tree/master/src/public/svg

In which files do you see any base64 encoding?

from opencollective-frontend.

XhmikosR avatar XhmikosR commented on August 20, 2024

Not related. This is for the SVGs that include a base64 PNG. The other issue is for base64 encoding the whole SVGs.

An example is https://github.com/opencollective/frontend/blob/35f52ebde057bd80e4a65331c4748e14da57d6e4/src/static/images/organization.svg

More results in https://github.com/opencollective/frontend/search?q=base64&unscoped_q=base64

from opencollective-frontend.

znarf avatar znarf commented on August 20, 2024

I agree, the example you provided organization.svg should be a pure svg and not contain any base64.

from opencollective-frontend.

XhmikosR avatar XhmikosR commented on August 20, 2024

There are many more, just look at the codebase :)

from opencollective-frontend.

znarf avatar znarf commented on August 20, 2024

For the SVGs in the static folder, if you have a solution, feel free to submit a PR and provide the command to do it. I don't think that needs to be in the build process now, fixing the files in the repository should be enough.

from opencollective-frontend.

XhmikosR avatar XhmikosR commented on August 20, 2024

No, this needs to be done manually because the PNGs that are in the SVGs serve a purpose visually :P

from opencollective-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.