Multiple shared libraries using libmetal about libmetal HOT 7 CLOSED

This seems to be a bug in the Linux libmetal implementation. The function returns void, so it can't return an error on multiple invocations, but it should not create a segfault.

from libmetal.

@sjd-xlnx Can you try #185 to see if this fixes your issue? It works in my limited testing.

from libmetal.

This entire problem could be avoided if libmetal took advantage of the ELF initialization and finalizations sections like most Linux (and other?) libraries. We could avoid the need for explicit initialization and finalization functions entirely.

from libmetal.

Hi, I looked at the proposed change, and it doesn't look right to me.

void metal_finish(void)
{
	/* if metal_init() failed, or metal_finish() is called twice, just return */
	if (_metal.common.initialized)
		return;
	metal_sys_finish();
	memset(&_metal, 0, sizeof(_metal));
}

Shouldn't it be something like this...

void metal_finish(void)
{
	/* if metal_init() failed, or metal_finish() is called twice, just return */
	if (!_metal.common.initialized)
		return;
	metal_sys_finish();
	memset(&_metal, 0, sizeof(_metal));
}

or ...

void metal_finish(void)
{
	/* if metal_init() failed, or metal_finish() is called twice, just return */
	if (_metal.common.initialized) {
		metal_sys_finish();
		memset(&_metal, 0, sizeof(_metal));
	}
	return;
}

from libmetal.

You're absolutely correct. The '!' is in my source tree but not in git. I must have messed something up in my edit.

from libmetal.

This issue has been marked as a stale issue because it has been open (more than) 45 days with no activity.

from libmetal.

Should be Fixed by #239, please reopen the issue if not the case.

from libmetal.