Git Product home page Git Product logo

Comments (5)

gtourkas avatar gtourkas commented on June 5, 2024 2

@MrAlias may I pick this up ?

from opentelemetry-go-contrib.

pellared avatar pellared commented on June 5, 2024 2

@ravilushqa @jay-manday @jjmengze @gtourkas
Could you please try to collaborate and select one of your PRs as a preferred one (and make other PRs as a draft) to make the reviewers' life easier? 😉

from opentelemetry-go-contrib.

ravilushqa avatar ravilushqa commented on June 5, 2024 2

@pellared
This issue how i see opened for graph-gophers/graphql-go lib, whereas mine and @jjmengze is for 99designs/gqlgen. I'm not sure that both lib should go in a one MR, and imo that would be harder for reviewers.

In situation with @jjmengze, our pr's are both for a one lib. I'm not experienced contributor, so i'm not pretty sure how to deal with that. I'm pretty long waiting for it, and I will be happy if we will collaborate around it.

My suggest is to contribute separately this one, and mine #761 :)

from opentelemetry-go-contrib.

gtourkas avatar gtourkas commented on June 5, 2024

@pellared

@ravilushqa sufficiently described the case: this PR for for graph-gophers/graphql-go, which is also what the issue #85 is about, and the other two for 99designs/gqlgen . Apart from the registry item, which I guess is the last step, the PR is imo ready for review.

from opentelemetry-go-contrib.

MrAlias avatar MrAlias commented on June 5, 2024

In accordance with the new instrumentation policy hosting guidelines I'm closing this.

from opentelemetry-go-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.