Comments (5)
@MrAlias may I pick this up ?
from opentelemetry-go-contrib.
@ravilushqa @jay-manday @jjmengze @gtourkas
Could you please try to collaborate and select one of your PRs as a preferred one (and make other PRs as a draft) to make the reviewers' life easier? 😉
from opentelemetry-go-contrib.
@pellared
This issue how i see opened for graph-gophers/graphql-go lib, whereas mine and @jjmengze is for 99designs/gqlgen. I'm not sure that both lib should go in a one MR, and imo that would be harder for reviewers.
In situation with @jjmengze, our pr's are both for a one lib. I'm not experienced contributor, so i'm not pretty sure how to deal with that. I'm pretty long waiting for it, and I will be happy if we will collaborate around it.
My suggest is to contribute separately this one, and mine #761 :)
from opentelemetry-go-contrib.
@ravilushqa sufficiently described the case: this PR for for graph-gophers/graphql-go, which is also what the issue #85 is about, and the other two for 99designs/gqlgen . Apart from the registry item, which I guess is the last step, the PR is imo ready for review.
from opentelemetry-go-contrib.
In accordance with the new instrumentation policy hosting guidelines I'm closing this.
from opentelemetry-go-contrib.
Related Issues (20)
- Deprecate and remove go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws HOT 2
- Deprecate and remove go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful HOT 1
- Deprecate and remove go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux HOT 1
- Deprecate and remove go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho
- Deprecate and remove go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo HOT 6
- Deprecate and remove go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron
- Deprecate and remove go.opentelemetry.io/contrib/propagators/aws HOT 7
- Deprecate and remove go.opentelemetry.io/contrib/samplers/aws/xray HOT 5
- why otelhttptrace duplicate? HOT 6
- Incorrect conversion between integer types HOT 4
- Nested http spans from different modules HOT 2
- Rebuild .tools as they can be outdated
- log bridges must not depend on SDK HOT 12
- For golang `go.opentelemetry.io/contrib/config` is not an ideal name HOT 2
- Upgrade all use of go.opentelemetry.io/otel/semconv/v1.24.0 to use v1.25.0 HOT 1
- Reflected cross-site scripting HOT 1
- ec2 detector does not respect context timeout HOT 1
- Update runtime instrumentation to new semantic conventions HOT 3
- Add codespell to CI HOT 4
- Incorrect conversion of an unsigned 64-bit integer from strconv.ParseUint to a lower bit size type uint8 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-go-contrib.