Detect `service.version` from Assembly Version? about opentelemetry-dotnet HOT 2 OPEN

@Aaronontheweb

Here are my thoughts...

• You could definitely add this as-is over in https://github.com/open-telemetry/opentelemetry-dotnet-contrib. If you want to just do that and stop reading, fine by me.

• I think this is useful enough it could be part of the main SDK. I don't speak for all approvers/maintainers, but I would be supportive of something like...

   public static ResourceBuilder AddServiceVersionDetector(
      this ResourceBuilder resourceBuilder,
      Assembly targetAssembly,
      ServiceResourceVersionDetectionType detectionType)
   {
      // ...
   }
  
  public enum ServiceResourceVersionDetectionType
  {
     AssemblyVersion,
     AssemblyFileVersion,
     AssemblyInformationVersion
  }

  I added the ability to look at AssemblyFileVersionAttribute & AssemblyInformationalVersionAttribute as well via the enum. For a project like OTel, AssemblyVersion is always 1.0.0.0 and AssemblyFileVersion \ AssemblyInformationalVersion are the more useful things. This actually follows the guidance, but I know a lot of users don't. Basically I think we should be able to look different spots and perhaps add more in the future?

from opentelemetry-dotnet.

@CodeBlanch, I would vote for your extended proposal, but in the contrib repository. I do not think that it is defined in spec/semantic convention to put it as a part of SDK.

If we speaking about detection, from particular assemblies, we are doing something similar for scope version. Keep in mind that part of the versioning system extends versions by suffixes (eg. GH commits). Ref: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/9114d0b183def59bc0cd747bdee024aae7d35fbc/src/Shared/AssemblyVersionExtensions.cs

from opentelemetry-dotnet.