Comments (4)
I see you are asking if the asp.net core instrumentation should do this by default, without having to write the Enrich? Then the answer is generally no, as the instrumentation follows otel conventions, and there isn't anything about "cancellation requested". It is possible to propose something to the Otel Semantic Conventions group, but its usually accepted for very common things. Your best bet would likely be to do such customizations via Enrich itself.
from opentelemetry-dotnet.
Can you clarify the ask some more?
from opentelemetry-dotnet.
Sure.
Here is an example of how we could do it with enrich.
.AddAspNetCoreInstrumentation(opts =>
{
opts.Enrich = (string _, HttpContext context, ref TagList tags) =>
{
tags.Add("cancelled", context.RequestAborted.IsCancellationRequested);
};
})
from opentelemetry-dotnet.
thanks @cijothomas that makes sense.
I looked around in the semantic conventions at this PR and this open issue
https://opentelemetry.io/docs/specs/semconv/http/http-spans/#common-attributes
According to the docs for error.type we could stipulate timeout or requestAborted in the error.type.
Currently a request would display as successful in the traces/metrics but actually be aborted (aka failed)?
from opentelemetry-dotnet.
Related Issues (20)
- [Instrumentations] ActivitySource and Meter versioning
- Expand test coverage for baggage encoding
- unit "bytes" not a suffix of metric "process_runtime_dotnet_gc_allocations_size_bytes_total" HOT 4
- Dotnet Otel Grpc hits client limit and drops messages. Event with default batch settings. HOT 12
- After update to 1.8 version and when using the ASP .Net Core Prometheus exporter and /metrics end point I get error on Prometheus some times. HOT 3
- [logs] Reloading application configuration may lead to unnecessary thread creation
- Prometheus exporter sometimes produces malformed data HOT 4
- DelegatingOptionsFactoryServiceCollectionExtensions breaks native AoT compatibility HOT 1
- Test stability - OpenTelemetry.Trace.Tests.BatchExportActivityProcessorTest.CheckShutdownExport HOT 2
- Move remaining instrumentation libraries to the opentelemetry-dotnet-contrib repo HOT 5
- Release changes for unstable core components HOT 2
- Tests Stability - OpenTelemetry.Instrumentation.AspNetCore.Tests.BasicTests
- Exception is thrown on non-standard IOC container due to use of Concrete classes. HOT 6
- [otlp] UseOtlpExporter and AddOtlpExporter extensions don't play nice together HOT 1
- Instrumentation.AspNetCore and Instrumentation.Http 1.8.1 have illegal breaking changes in the produced telemetry HOT 8
- service.name is defined as unknown_service HOT 2
- service.name is defined as unknown_service HOT 4
- ASP.NET http.route appears to be incorrect when exception handlers are invoked HOT 3
- [docs-metrics] Show AddView API using delegate HOT 2
- ILogger logs not reflecting correct application name HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-dotnet.