Comments (4)
I believe keeping Abstractions is pretty consistent with .NET practices (Microsoft ships a lot of packages named like Microsoft.Extensions.Logging.Abstractions
or Microsoft.AspNetCorte.Http.Abstractions
) and we should keep it here.
I recall OpenCensus had the statement somewhere that typical language practices should be used - can't find it now, do we still prefer it over having the same API everywhere in OpenTelemetry?
from opentelemetry-dotnet.
Idiomatic language practices are good, but what worries me is that we'll end up polluting OpenTelemetry.Abstractions
with interfaces that are specific to the reference implementation.
from opentelemetry-dotnet.
For me it was a bit confusing at first, not finding the "Api" and "Sdk" layers anywhere. Also "Api" and "Sdk" terms come up in conversations sometimes and it's a bit weird to not have them reflected in the project names.
However, no strong opinion on this. It's good to be idiomatic to a tech.
Concerning "Abstractions": Which interfaces is it supposed to hold exactly?
- For implementers of "Instrumentations"
- For implementers of "Tracers"
- For implementers of "Exporters"
Currently, all the above I would guess. Would it make sense to split out 1. into an "Api" project with minimal API surface?
from opentelemetry-dotnet.
I have the same reservations about Abstractions
. SDK will have bigger public surface area than API. API package will mostly be for the libraries instrumentation like OpenTracing before
from opentelemetry-dotnet.
Related Issues (20)
- Stabilize OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES
- Review coding styles settings
- Support for HTTP Client Request/Response Body Size Metrics HOT 1
- [epic] Replace TagTransformer with a higher perf solution
- Unintentional breaking changes? `MethodAccessException` when attempting to migrate from v1.7.0 to v1.8.0-beta.1 HOT 7
- [BaggagePropagator] Do not encode and decode keys
- envvar-based sampler configuration capability should not be mentioned as part of `1.8.0-beta.1` changelog HOT 2
- Getting duplicate metrics being sent from azure function HOT 5
- Ability to disable timestamps at the end of a metric
- Support .NET 9 Advice API
- [Instrumentation.AspNetCore, Instrumentation.Http] Cache activity names
- Why is the parentId of the called service not the one of the caller service? HOT 2
- [Instrumentations] ActivitySource and Meter versioning
- Expand test coverage for baggage encoding
- unit "bytes" not a suffix of metric "process_runtime_dotnet_gc_allocations_size_bytes_total" HOT 2
- Dotnet Otel Grpc hits client limit and drops messages. Event with default batch settings. HOT 12
- After update to 1.8 version and when using the ASP .Net Core Prometheus exporter and /metrics end point I get error on Prometheus some times. HOT 2
- [logs] Reloading application configuration may lead to unnecessary thread creation
- Prometheus exporter sometimes produces malformed data HOT 1
- DelegatingOptionsFactoryServiceCollectionExtensions breaks native AoT compatibility HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-dotnet.