Git Product home page Git Product logo

Comments (4)

lmolkova avatar lmolkova commented on May 23, 2024

I believe keeping Abstractions is pretty consistent with .NET practices (Microsoft ships a lot of packages named like Microsoft.Extensions.Logging.Abstractions or Microsoft.AspNetCorte.Http.Abstractions) and we should keep it here.
I recall OpenCensus had the statement somewhere that typical language practices should be used - can't find it now, do we still prefer it over having the same API everywhere in OpenTelemetry?

from opentelemetry-dotnet.

austinlparker avatar austinlparker commented on May 23, 2024

Idiomatic language practices are good, but what worries me is that we'll end up polluting OpenTelemetry.Abstractions with interfaces that are specific to the reference implementation.

from opentelemetry-dotnet.

discostu105 avatar discostu105 commented on May 23, 2024

For me it was a bit confusing at first, not finding the "Api" and "Sdk" layers anywhere. Also "Api" and "Sdk" terms come up in conversations sometimes and it's a bit weird to not have them reflected in the project names.

However, no strong opinion on this. It's good to be idiomatic to a tech.

Concerning "Abstractions": Which interfaces is it supposed to hold exactly?

  1. For implementers of "Instrumentations"
  2. For implementers of "Tracers"
  3. For implementers of "Exporters"

Currently, all the above I would guess. Would it make sense to split out 1. into an "Api" project with minimal API surface?

from opentelemetry-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on May 23, 2024

I have the same reservations about Abstractions. SDK will have bigger public surface area than API. API package will mostly be for the libraries instrumentation like OpenTracing before

from opentelemetry-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.