Git Product home page Git Product logo

Comments (7)

SergeyKanzhelev avatar SergeyKanzhelev commented on June 6, 2024

Resource is now in specs: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resources-api.md and https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/tracing-api.md#constructing-spandata

Need to move abstract class to API, get rid of interface and add Resource to the SpanData.

from opentelemetry-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on June 6, 2024

@trwegner do you want to take it?

from opentelemetry-dotnet.

trwegner avatar trwegner commented on June 6, 2024

Sure! I'll start this afternoon.

from opentelemetry-dotnet.

trwegner avatar trwegner commented on June 6, 2024

@SergeyKanzhelev and @lmolkova - to move Resource abstract class requires also moving Tag, TagKey and TagValue. Any objection to removing the corresponding Tag* interfaces along the the Resource one?

from opentelemetry-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on June 6, 2024

yep. This is fine: https://github.com/open-telemetry/opentelemetry-java/blob/4172855fcdefc5d11cf52a974aeaf8de572c9f96/api/src/main/java/io/opentelemetry/tags/Tag.java#L30

from opentelemetry-dotnet.

trwegner avatar trwegner commented on June 6, 2024

Great! Thanks Sergey.

from opentelemetry-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on June 6, 2024

Closed via #97

from opentelemetry-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.