Git Product home page Git Product logo

Comments (5)

tigrannajaryan avatar tigrannajaryan commented on June 29, 2024

@pjanotti perhaps we can remove makefiles from individual component directories? Are they needed if there is a full build now?

from opentelemetry-collector-contrib.

owais avatar owais commented on June 29, 2024

I agree. We should remove the individual ones. If the components need some special targets, we can add them to root makefile and have an argument that allows users to run targets against a component. Something like make test-component COMPONENT='receiver/zipkin'

from opentelemetry-collector-contrib.

pjanotti avatar pjanotti commented on June 29, 2024

This is a convenience in order to avoid full build as the number of components increases, it can be replaced by adding targets but it seems simpler to simply factor out the common parts and have Makefile using some of the same targets from common.

from opentelemetry-collector-contrib.

pjanotti avatar pjanotti commented on June 29, 2024

I think my initial description gave the impression about keeping them in sync, that was not my intention: the intention is to have a single source for the common targets.

from opentelemetry-collector-contrib.

pjanotti avatar pjanotti commented on June 29, 2024

Edited the initial description.

from opentelemetry-collector-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.