Git Product home page Git Product logo

Comments (2)

tigrannajaryan avatar tigrannajaryan commented on June 3, 2024

Generally, I do not think we should expose Sender directly. If we need to send a message then it should be exposed in the OpAMPClient interface, similar to for example SetEffectiveConfig. Let's keep Sender in internal.

Report failing health of the agent or worse, termination status of the agent.
Report agent restart metrics.

I think these are both expected to be reported via own telemetry, so shouldn't be done via OpAMP. What OpAMP message do you want to send for these 2 cases?

Report agent package or addon download progress.

This should happen in response to the OnAddonsAvailable/OnAgentPackageAvailable callbacks. The AddonSyncer and AgentPackageSyncer are supposed to have the context to report the progress. Are these not sufficient?

from opamp-go.

kart avatar kart commented on June 3, 2024

I think you are right. I was thinking that there might be separate telemetry needs from the supervisor -- reporting the up/down stats of the collector, but the spec as it stands today doesn't talk about this at least not in the context of the supervisor. And as to the agent/addon download status, etc, the syncer should be a good place.

from opamp-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.