Git Product home page Git Product logo

Comments (9)

bdougie avatar bdougie commented on May 20, 2024 2

The solution for anyone who encounters this is to unregister the service worker. We can work on a fix to automate this, but for now, I think this is a viable solution for the 165 (out of 2300 uniques referenced above) active users.

image

Be sure to refresh after you click ungregister.

from open-sauced.

0-vortex avatar 0-vortex commented on May 20, 2024

Hey, thanks for adding this issue, back in v0.42.5 the service worker wasn't correctly checking for new versions, hence why some assets on that redirect are not loading. Refreshing the page once without cache or deleting local *.opensauced.pizza should fix the error locally. Unfortunately, we cannot retroactively solve v0.42.5 but the problem is solved, currently. Do you think a page in the docs obout this issue and how to clear the session would make sense?

cc @bdougie had this issue on stream once as well, what do you think?

from open-sauced.

wotta avatar wotta commented on May 20, 2024

Thanks for the quick reply @0-vortex.
I'm not fully sure if the page in the docs is a needed. I have the feeling that I'm one of the handful of people who will encounter this issue.

But since this repository is based on getting people introduced with opensource contributions, I am not gonna shoot down an opportunity for someone in the very basics of opensource contributions.

from open-sauced.

bdougie avatar bdougie commented on May 20, 2024

Yeah, we need to clear the cache aggressively for users. The site was getting 2300 uniques a month before the change, so I imagine a not insignificant amount of people will encounter this.

from open-sauced.

bdougie avatar bdougie commented on May 20, 2024

I have added the following code to a Netlify snippet injection. It's deployed, just need someone to confirm it works now.

navigator.serviceWorker.getRegistrations().then(function(registrations) {
 for(let registration of registrations) {
  registration.unregister()
} })

from open-sauced.

0-vortex avatar 0-vortex commented on May 20, 2024

I have added the following code to a Netlify snippet injection. It's deployed, just need someone to confirm it works now.

navigator.serviceWorker.getRegistrations().then(function(registrations) {
 for(let registration of registrations) {
  registration.unregister()
} })

This makes the service worker stop working for everyone - with no registered resources you would never have the app available offline, the issue is visible by the lack of SW is ready to handle offline requests. message in the console :D

from open-sauced.

bdougie avatar bdougie commented on May 20, 2024

My reason for putting it in netlify was to fix it now and remove it a month or so. I would rather have the sw not work than get pings that the site is not working entirely a user.

Path of least resistance?

from open-sauced.

wotta avatar wotta commented on May 20, 2024

Unfortunately I am not able to test this behaviour because I already removed my service worker.
Is there a way to visit an old version of the deployment to activate the old SW?

from open-sauced.

0-vortex avatar 0-vortex commented on May 20, 2024

Closing this as won't fix - we might merge app and hot and when that happens, this could be corrected, however might not happen this year! 🍕

from open-sauced.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.