Git Product home page Git Product logo

Comments (9)

diivi avatar diivi commented on August 21, 2024 1

I think I can patch it in the PR right now.

We can, but It's better to keep some issues open for new contributors.

from ai.

a0m0rajab avatar a0m0rajab commented on August 21, 2024 1

Sure, it would be faster, I will check his PR later to understand how it got fixed 👍

from ai.

diivi avatar diivi commented on August 21, 2024

Nice catch! I knew this was happening but wasn't able to reproduce it. @a0m0rajab do you want to work on this (it's fine if you don't)?

from ai.

Anush008 avatar Anush008 commented on August 21, 2024

I think I can patch it in the PR right now.

from ai.

a0m0rajab avatar a0m0rajab commented on August 21, 2024

@diivi it took me some time to understand how to reproduce it LOL!
I can work on it but I have a lot on my plate right now, I might need 3-4 days to work on it though. if that's okay.

from ai.

diivi avatar diivi commented on August 21, 2024

That's okay, but if Anush is working on the component right now, I guess it's fine if he fixes it in his current PR.

from ai.

Anush008 avatar Anush008 commented on August 21, 2024

There's a check for this in place. Which seemed to work when I tested it. I'll have to do some digging to find the edge case here.
https://github.com/open-sauced/browser-extensions/blob/2e35735c0c48dd04434da3ef995f5b4469b969d6/src/utils/dom-utils/addDescriptionGenerator.ts#L14

from ai.

github-actions avatar github-actions commented on August 21, 2024

🎉 This issue has been resolved in version 1.2.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from ai.

github-actions avatar github-actions commented on August 21, 2024

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.