Git Product home page Git Product logo

Comments (4)

zgypa avatar zgypa commented on June 19, 2024

Actually, ideally, if the medical provider decides that the camera capturing resolution in lossy JPG is enough, that image should be taken as such, encapsulated in DICOM, tagged as lossy compression and archived that way. This means there are two use cases for this ticket:

Use Case 1: Ideal, Maximum Resolution, medium space

as mentioned in description

  • capture image in RAW format
  • pass it to dicom4ortho
  • have dicom4ortho compress is using some lossless compression algorithm like JPEG2000
  • save image in DICOM (as encapsulated)

Use Case 2: Compressed image, lower resolution, lowest space consumption

  • Camera is set to save in JPG
  • Images are converted to DICOM, untouched, as JPEG
  • Encapsulation
  • Proper Tagging as Lossy Compression

Use Case 3: RAW, uncompressed, max resolution, max space usage

  • Camera is set to save as RAW
  • RAW conversion to DICOM, no compression. Straight byte array storage

However, currently the software does none of these use cases. This documentation should probably go in ADA-1107

from dicom4ortho.

zgypa avatar zgypa commented on June 19, 2024

Created branch feature/9-jpg-encapsulation

from dicom4ortho.

zgypa avatar zgypa commented on June 19, 2024

Implemented and merged back into develop.

Not too happy with how i handle JPEG2000. But for the current usecase, which is to import JPEG2000 images from topsServer, it is fine, becuase these are already compressed. I'm pretty sure they are not JPEG2000 lossless, because they are too small for that. I mean, it's possible that the conversion from JPG to JPEG2000 was very clean and without information or space loss. But then i have to figure out how to keep that JPEG2000 the it is, without touching it. But encapsulation requires a byte array, so i'm not too sure how to handle this. For the moment, this works.

from dicom4ortho.

zgypa avatar zgypa commented on June 19, 2024

Fixed issue. Now i'm happy with it. Encapsulation is exactly what the word says (for once!!): takes the JPG or JPEG2000 the way it is, with header and all, and saves it in the DICOM PixelData. TransferSyntax needs to be set appropriately. Done that now, and all works as expected.

from dicom4ortho.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.