problem with qla2xxx wwn conversion to naa.* about rtslib-fb HOT 6 CLOSED

the problem lies in rtslib/fabric.py

def _list_targets(self):
    if self.exists:
        for wwn in os.listdir(self.path):
            if os.path.isdir("%s/%s" % (self.path, wwn)) and \
                    wwn not in target_names_excludes:
                yield Target(self, self.from_fabric_wwn(wwn), 'lookup')

this code reads the directories under /sys/kernel/config/target/qla2xxx/ and finds a directory named 21:00:00:24:ff:36:96:52. It then tries to normalize as a naa wwn_type and fails.

from rtslib-fb.

Thanks for the detailed bug report. I'll try to get going on a machine with that hardware.

In the meantime, sounds like the from_fabric_wwn() is wrong? Maybe try:

    def from_fabric_wwn(self, wwn):
        return "naa." + wwn.translate(None, ":")

at rtslib/fabric.py line 415?

from rtslib-fb.

got on a test box. this seems to work, same spot:

    def from_fabric_wwn(self, wwn):
        if wwn.startswith("0x"):
            wwn = wwn[2:]
        return "naa." + wwn.translate(None, ":")

Please confirm this fixes it for you as well? Thanks!

from rtslib-fb.

Sorry for the delay. Evening here.
I just tried the fix.
It seems to work correctly.
No visible side effect.

Thank you for your responsiveness.

P.S.: the Fedora 18's published version is completely screwed regarding qla2xxx...

from rtslib-fb.

yup I'll be updating fedora pkgs very soon.

from rtslib-fb.

Awesome, I think I hit this during the last storage class I gave. I used Fedora there. Some many thanks to both of you.

from rtslib-fb.