openssl binary usage about optee_test HOT 9 CLOSED

As they're host binaries, presumably just expecting libcrypto on the host is acceptable?

from optee_test.

As they're host binaries, presumably just expecting libcrypto on the host is acceptable?

The word "host" is incorrectly used here, we're talking about the client application (xtest) which contains the test drivers that invoke the TAs. So to be clear, this application runs on the target platform, in Linux (not in OP-TEE).

I agree that the OpenSSL binaries need to be removed. The CMake build doesn't use them already. For example the QEMU build documented at https://optee.readthedocs.io/en/latest/building/devices/qemu.html#qemu-v8 uses Buildroot and the CMake files and will build OpenSSL from source.

from optee_test.

I was able to remove the openssl binaries and openssl include files, modify the host/xtest/Makefile to use -lcyrpto and not reference the openssl include files, and everything appears to be mostly happy. I had to add " -Wno-error=deprecated-declarations" because it is using old versions of some functions.

If you want, I can upload the changes as a PR.

from optee_test.

@jonmason yes please!

from optee_test.

Feel free to take this jenswi-linaro@7238495

from optee_test.

@jenswi-linaro this looks good to me. Please close this issue when it is merged

from optee_test.

Feel free to take this jenswi-linaro@7238495

The above commit could probably be merged without waiting for OP-TEE 4.x, provided that this is added too: #689 [1]. @jenswi-linaro @jonmason what do you think?

[1] Tested with the Linaro TRS build which has OpenSSL 3.0 which is why the PR is needed

from optee_test.

Sound good to me. How about adding jenswi-linaro/optee_test@7238495 to #689?

from optee_test.

Sound good to me. How about adding jenswi-linaro/optee_test@7238495 to #689?

Done!

from optee_test.