Git Product home page Git Product logo

Comments (6)

oodesign avatar oodesign commented on June 14, 2024

Hi! Thanks for the feedback!

We just released an update (v1.1.1) that should fix this performance issues. We're still working on some other fixes, but in the meanwhile... may you give it a try and tell us how did it work for you?

Thank you!

from merge-duplicate-symbols.

RaphyRaph avatar RaphyRaph commented on June 14, 2024

I have v1.1.1 and it still crashes on my first merge attempt :(

from merge-duplicate-symbols.

oodesign avatar oodesign commented on June 14, 2024

May you tell us some more detail about the crash? Are you able to see the first merge screen? Does it crash when you hit "OK" for the very first merge decision?
Having the original Sketch file would be really helpful. Any chance that you forward us the file, or an adapted version that may be shared?

Thanks!

from merge-duplicate-symbols.

oodesign avatar oodesign commented on June 14, 2024

Hi!

We just released version 2.0.0, which adds the "Continue later" option, displays symbol usage data (to ease decision making), and also reduces the performance issues drastically (we changed the way we iterate through layers and pages and works like 3 times faster).

Even though, it will still take some seconds to iterate through all objects if you have lots of pages and layers.

We tested it on a 80 page Sketch file with up to 10 layers per page and gave us performance times lower than 5-6 seconds.

Please, let us know if you're still having issues with it on your files. If you do, having the Sketch files you're trying it on would be really great to test it out.

Thanks!

from merge-duplicate-symbols.

RaphyRaph avatar RaphyRaph commented on June 14, 2024

A lot better! IT mostly works now. Here are some great next steps:

  • choose a symbol/multiples symbols and replace all instances of that symbol with another symbol (with the option to keep/override the dimensions)
  • offer to merge symbols with similar dimensions (for the case of renamed symbols)
  • have a helper that offers to merge symbols when new duplicates get added to the file
  • do the same for text styles
    THX

from merge-duplicate-symbols.

nickerups avatar nickerups commented on June 14, 2024

Performance is still a bit slow, and CPU usage jumps. But it all works correctly now! Nice work.

from merge-duplicate-symbols.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.