Replacement Fails on Sketch 51 about merge-duplicate-symbols HOT 28 CLOSED

@stdk00 Having that case to test & debug really helped!
Happy it works again for you! :)

from merge-duplicate-symbols.

just got back from holiday. new version works for me. Thanks!

from merge-duplicate-symbols.

yup having the same problem under sketch 51.1 replacements aren't working

from merge-duplicate-symbols.

Hi!

Sad to hear you're having issues with the plugin... we'll do our best to fix it as soon as possible.

Meanwhile, would it be possible to have one of those files you work with to run some tests and debugging on our own? Feel free to remove anything that you wouldn't like to share, but keeping the nested symbols or instances...

Thank you!

from merge-duplicate-symbols.

Hi @ninzucchi and @stdk00,

We haven't been able to reproduce the issue you're describing.
May you send us the affected files to run some tests on our own? Feel free to remove anything that you wouldn't like to share (keeping the symbols and removing its content is fine too). Just make sure that the affected symbols, nested symbols or instances are there...

Thanks!

from merge-duplicate-symbols.

@oodesign thanks for putting time on this. I'll try to put together a file, although the behavior is very erratic. sometimes it works, sometimes it doesn't. so i completely understand how hard it will be to replicate this. sometimes it even ignores some symbols that are duplicated. i'm trying to figure out the pattern.

In the meantime is there some other information that might help you out?

thanks a lot

from merge-duplicate-symbols.

Thank you for arranging a sample file, @stdk00, that will definetely help figure out the problem :)

By the way... may we have a list of your currently installed plugins? Have you noticed if Merge Duplicates Symbols started failing after installing a specific plugin? In the past we've had some issues with plugins (like Diya) that include some wrappers to symbols, changing its internal definition.

Thank you!

from merge-duplicate-symbols.

these are the only plugins i use:

it became more erratic when i've updated to sketch 51, but today is working good. i work with very large files with a lot of nested symbols and the issue just happens from time to time so it will be very hard to replicate or isolate in a file.

from merge-duplicate-symbols.

I'm having the same problem. What I have observed is that when it quits on the merge of a certain symbol, it quits on the same symbol the next time I try.

default	14:21:24.300167 +0200	Sketch	Exception: TypeError: currentOverrides[keyIndex].allKeys is not a function. (In 'currentOverrides[keyIndex].allKeys()', 'currentOverrides[keyIndex].allKeys' is undefined)

default	14:21:24.300284 +0200	Sketch	TypeError: currentOverrides[keyIndex].allKeys is not a function. (In 'currentOverrides[keyIndex].allKeys()', 'currentOverrides[keyIndex].allKeys' is undefined)
line: 46
sourceURL: /Users/adam/Library/Application Support/com.bohemiancoding.sketch3/Plugins/MergeDuplicateSymbols.sketchplugin/Contents/Sketch/MergeDuplicateSymbols.cocoascript
column: 79
stack: MergeSymbols@/Users/adam/Library/Application Support/com.bohemiancoding.sketch3/Plugins/MergeDuplicateSymbols.sketchplugin/Contents/Sketch/MergeDuplicateSymbols.cocoascript:46:79
onRun@/Users/adam/Library/Application Support/com.bohemiancoding.sketch3/Plugins/MergeDuplicateSymbols.sketchplugin/Contents/Sketch/MergeDuplicateSymbols.cocoascript:347:21

from merge-duplicate-symbols.

Hi @amchap !
Do you have a specific symbol that always causes the plugin to crash? May you create a new Sketch files with that symbol and a new symbol with the same name, ant try to run the plugin?

Or further than this... may you send us the Sketch file with that symbol to run some tests and debugging on our own?

Thank you!

from merge-duplicate-symbols.

@oodesign Hi there, I believe I've managed to isolate the issue in a file.
DuplicatedSymbol_Issue.zip

Basically, there is a symbol called "Icon/DateGreySmall" which is duplicated: same exact name and content. Both copies are individually nested in a separated symbol. If you try to merge that symbol, the plugins detect the duplication but fails to do the replacement. you can keep trying and the plugin keeps detecting the duplication but does nothing.

here is a link of screen capture i've made to show you the issue:
https://drive.google.com/open?id=1_EOv9Po1E4MUZe_EqM0EZbMBxmtx9Zp5

Let me know if this helps.
Thanks

from merge-duplicate-symbols.

Thank you @stdk00!

It will definetely help us understand what's going wrong.
We'll let you know when we find the issue and release a fix for that.

Thank you!

from merge-duplicate-symbols.

Hello! @ninzucchi @stdk00 @amchap

We just released version 3.0.8, which hopefully solves the issues causing the plugin to crash and do apparently nothing.
We've been running it all over our unit tests and everything seems to work fine and performant, but please, try it out and let us know if you still have any issues.

Thanks you all again for the feedback and reporting the issues :)

from merge-duplicate-symbols.

@oodesign nice, that was fast! I've tested and it's working. if something else comes up i'll let you know. Thank you so much for your time.

from merge-duplicate-symbols.

from merge-duplicate-symbols.

@oodesign hi all. I hate to give bad news but I must say that the problem is still there. the plugin update solved it for a while, but it's back again and it's exactly as before. I haven't installed any new plugins or sketch updates. its the same configuration i had previously. :(

from merge-duplicate-symbols.

@stdk00 Sad to hear it's failing again!

May you send us a sample Sketch file, or attach the plugin output log?

Thank you!

from merge-duplicate-symbols.

@oodesign how can i send you the plugin output log? sorry i have never done that before

from merge-duplicate-symbols.

@stdk00 Probably the easiest way is that you run the plugin as a script and send us the log.
In Sketch, under the Plugins menu you'll find a "Run Script" option (⌃+⬆️+K).

Copy the plugin raw code from here and paste it in the first big text box. Then, click Run.

If everything works fine, nothing should appear in the second box (result). If there's any exception copy the exception text in it and send it over to us :)

Thank you!

from merge-duplicate-symbols.

@oodesign here you go. this is what is shown as result:

`TypeError: currentOverrides[keyIndex].allKeys is not a function. (In 'currentOverrides[keyIndex].allKeys()', 'currentOverrides[keyIndex].allKeys' is undefined)
line: 52
sourceURL: /Users/rafaelmatosdasilva/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Untitled.sketchplugin
column: 83
stack: MergeSymbols@/Users/rafaelmatosdasilva/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Untitled.sketchplugin:52:83
onRun@/Users/rafaelmatosdasilva/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Untitled.sketchplugin:354:21

Script executed in 6.178903s`

from merge-duplicate-symbols.

@stdk00 Thanks!

May you please grab the raw code again (we've added a few changes), run it with "Run Script", and send us the result?

#RemoteDebugging :D

Thank you!

from merge-duplicate-symbols.

:D

Here it is

`'CurrentOverrides: {\n "518D7B50-E6A3-4929-B3C1-CABFA34DDF7D" = {\n symbolID = "40D159A7-BAC7-4A67-AD66-50BE32F6E00C";\n };\n "5F06DDE3-6288-4DAA-BFB5-646F27D7FE2B" = "\Ue639";\n "CB37FB6A-BAA7-4512-B6C9-9760734ED0B9" = "Cr\U00e9dito Sal\U00e1rio";\n}'
'KeyIndex: 5F06DDE3-6288-4DAA-BFB5-646F27D7FE2B'
'currentOverrides[keyIndex]: '
TypeError: currentOverrides[keyIndex].allKeys is not a function. (In 'currentOverrides[keyIndex].allKeys()', 'currentOverrides[keyIndex].allKeys' is undefined)
line: 55
sourceURL: /Users/rafaelmatosdasilva/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Untitled.sketchplugin
column: 83
stack: MergeSymbols@/Users/rafaelmatosdasilva/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Untitled.sketchplugin:55:83
onRun@/Users/rafaelmatosdasilva/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Untitled.sketchplugin:357:21

Script executed in 5.053146s`

from merge-duplicate-symbols.

@stdk00 It seems there are Unicode characters in the override identifiers that shouldn't be there.
I'm afraid it won't get easy to remotely debug why this is happening, and don't like bothering you with this kind of stuff. May you send us a copy of your Sketch file* so that we can run further testing on our own?

(*) Obviously we won't share it in any way. Also, feel free to remove anything else from it (we just need the affected symbol).

Thank you!

from merge-duplicate-symbols.

@oodesign here is the file for you to test.
DuplicateIssue.sketch.zip

let me know if you need anything else.
Thanks a lot!

from merge-duplicate-symbols.

@stdk00 Awesome!
We'll make sure to let you know when we find the issue and release a fix.

Thank you!

from merge-duplicate-symbols.

@stdk00 Hi! We just released v3.0.9, that solves some of the issues.

Anyway, I'd like to ask you... is there any symbol (or layer, or other element) in your Sketch file (or the original Sketch file) named or containing the text "Crédito Salario"?

It appears in our logs as an existing element in the file, but haven't been able to find it exploring the design file... and that worries us :)

Thank you!

from merge-duplicate-symbols.

@oodesign yup, in the original file there was an override containing that text, but i've stripped everything from the file to isolate the issue. not sure why you guys still see that.

I've tested the new plugin update and its been working good.

Thank you so much for fixing this.

from merge-duplicate-symbols.

@stdk00 It seems the Sketch file keeps the override structure even if the instance is not there (not sure why). Anyway... that clue led us to discover we were trying to replace some instances and overrides that are not there, and forced the plugin to crash, so... thank you very much!

Happy it works again for you!

Let us know if you have further issues with it :)

from merge-duplicate-symbols.