Feature Request: Option to insert script at bottom of HTML body about redmine-view-customize HOT 9 CLOSED

It is okay to have a pull request in the current state.

Submitted PR.

I'll take care of the rest.

Thank you so much!!

from redmine-view-customize.

Released at v2.8.0.

Thanks!

from redmine-view-customize.

Thank you for your feature request.

What you want to do may be possible without additional features.
With the window load event, you'd be able to run it after the Gantt chart script.

$(window).on('load', function() {
  // your scripts
});

This is because the window load event occurs after $(function{}).

Would you please give it a try?
If you can't get around it here, we'd like to add a feature.

from redmine-view-customize.

Thanks!

I've tried it, but no success.
Actually, it worked with RedMica v1.1, but not works with RedMica v1.2.

I will try again and paste the script here later.

Anyway, I am trying to implement it...
https://github.com/iquiw/redmine-view-customize/tree/body-bottom

from redmine-view-customize.

Thanks for trying.

If the load event doesn't work, it may not work even if you use View customize to handle it.

from redmine-view-customize.

Here is the script, which saves and restores Gantt chart subject column width.

// https://stackoverflow.com/a/2523758
$.widget("ui.resizable", $.ui.resizable, {
  resizeTo: function(newSize) {
    let start = new $.Event("mousedown", { pageX: 0, pageY: 0 });
    this._mouseStart(start);
    this.axis = 'se';
    let end = new $.Event("mouseup", {
      pageX: newSize.width - this.originalSize.width,
      pageY: newSize.height - this.originalSize.height
    });
    this._mouseDrag(end);
    this._mouseStop(end);
  }
});

$(window).on('load', function() {
//$(function() {
  const GANTT_SUBJECT_WIDTH_KEY = 'redmine-gantt-subject-width';
  let $subject = $('.gantt_subjects_column.ui-resizable');
  $subject.resizable({
    stop: function(event, ui) {
      localStorage.setItem(GANTT_SUBJECT_WIDTH_KEY, ui.size.width);
    }
  });
  let width = localStorage.getItem(GANTT_SUBJECT_WIDTH_KEY);
  if (width) {
    $subject.resizable('resizeTo', { width: width, height: $subject.height() });
  }
});

As far as I tried the following combinations with RedMica v1.2,

• Browser: Chrome/Firefox
• Position: Head of all pages/Bottom of all pages
• Load: $(window).on('load'/$(function()

With Chrome, it works in the following cases.

With Firefox, it works only when using $(function() and Bottom of all pages.

(*1) worked with RedMica v1.1.

from redmine-view-customize.

Thank you for the information.

I don't understand why the window load doesn't work well in Firefox.
Is there some kind of error?

Either way, we are thinking of including this feature.

from redmine-view-customize.

I don't understand why the window load doesn't work well in Firefox.

It could be a bug of Firefox though I am not sure.

Is there some kind of error?

No error, $('.gantt_subjects_column.ui-resizable').length is 0 in the case.

Either way, we are thinking of including this feature.

Thanks!
I will try to add unit test and update README.
I am afraid I cannot update Chinese translation.

from redmine-view-customize.

Either way, we are thinking of including this feature.

Thanks!
I will try to add unit test and update README.
I am afraid I cannot update Chinese translation.

It is okay to have a pull request in the current state.
I'll take care of the rest.

Thanks.

from redmine-view-customize.