Git Product home page Git Product logo

Comments (3)

adibrastegarnia avatar adibrastegarnia commented on August 19, 2024

@Andrea-Campanella
I think it is already addressed correct? Can we close it?

from onos-test.

kuujo avatar kuujo commented on August 19, 2024

@adibrastegarnia it hasn't been changed. The code @Andrea-Campanella is referring to is here now:
https://github.com/onosproject/onos-test/blob/master/pkg/onit/cluster/cli.go#L89-L94

However, we can't make it separate key/value pairs in a ConfigMap because separate key/value pairs in a CM are mounted as separate files in the file system. But this is writing the configuration file used by Atomix, so it needs to be a single key. The only related improvement we could do here is encode a struct to YAML rather than writing a string.

from onos-test.

adibrastegarnia avatar adibrastegarnia commented on August 19, 2024

@kuujo
Good to know. I will take a look.

from onos-test.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.