Git Product home page Git Product logo

Comments (5)

eengstrom avatar eengstrom commented on June 9, 2024

Funny - I was just about to report the inability to specify a ttl lower than the 7/14 day defaults. Longer works, but not shorter.

from onetimesecret.

onetimesecret avatar onetimesecret commented on June 9, 2024

from onetimesecret.

jrogov avatar jrogov commented on June 9, 2024

Well, discussing it further, 1 hour seems the most appropriate to me, since I can imagine quite a few situtations where lesser ttl can be desired.
BTW, it's been said that this is for abuse prevention, but afaik there's per...day(?) secret limit you discussed right here. So, having these limits and considering common... user speed? I'd say the smallest still-appropriate ttl would be 1 minute. Just a proposal tho.

About s/m ttls. I understand why they are sent back, but generate have them as options. The problem here is that i checked and ttl's weren't set correspondingly to sent request. Do NOT consider this as a bug tho, 'cause I didn't tested it properly. 'll open another issue if I confirm my assumption

from onetimesecret.

delano avatar delano commented on June 9, 2024

Thanks for the follow up and clarification. I removed the unused query params from the docs.

The minimum TTL was a straight up bug as evidenced here:
6205faf#diff-36f8bb4628f358a7841a9c9be443d52dL419

The ticket auto-closed with the commit message but feel free to re-open if you find anything else for this. And thanks all for helping make onetimesecret better.

from onetimesecret.

jrogov avatar jrogov commented on June 9, 2024

Thanks.
But providing more functionality, separate metadata_ttl and secret_ttl are could still be reasonable to have in request params. Could be said that number of situtations where it could be usable is, like, almost zero. But still, if you want such a "weird" functionality - why not :D

from onetimesecret.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.